Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Skip by date or next day occurrence #49

Open
ChrisRenfrow opened this issue Nov 3, 2023 · 4 comments
Open

Enhancement: Skip by date or next day occurrence #49

ChrisRenfrow opened this issue Nov 3, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ChrisRenfrow
Copy link
Collaborator

It would be a nice QoL enhancement if one could skip being matched on a particular date or on the next occurrence of a day of the week.

Right now if I normally have availability for a pairing session on a particular day that I realize I won't be available for, I need to either remember to send skip tomorrow the day before, or change my availability in advance, remembering to set it back to my usual availability before the following week.1

Examples:

  • skip 2023-11-06 would skip matching on that particular date
    • Best for setting exceptions to availability days or weeks out
  • skip mon would skip matching on the next available Monday
    • At the time of writing this would achieve the same as above, but more conveniently2

I'm more than willing to start work on this when I have a moment. Just adding this issue for future reference or if someone else wants to have a go at it!

Footnotes

  1. This is all possible through scheduling Zulip messages to the pairing bot, but this isn't common knowledge nor something that I think most people would readily think to do

  2. Assuming no availability on weekends

@stillgreenmoss
Copy link
Collaborator

Hey @ChrisRenfrow! I love this idea and fully support implementing it in pairing bot just the way you described.

can I just go ahead and give you direct commit access to the repository so you can work on it easily? Though you can submit a PR if you want, our usual pattern is to just grant commit access since RC is such a high-trust context for collaboration :)

@ChrisRenfrow
Copy link
Collaborator Author

Sure that's fine by me. I'm also more than happy to follow the standard (low-trust) contribution routine as a form of practice. :)

@stillgreenmoss
Copy link
Collaborator

Ok cool beans :) I'll add you as a repo owner and then you can submit changes as a PR if you'd like for practice. Feel free to merge them yourself or do any fussing in the repo necessary to troubleshoot, and also feel free to request review from me (or anyone else you're working with!) on anything.

there's an issue right now with merging the dev branch to main that I don't fully understand -- feel free to investigate or also tap me for async or synchronous pairing help. The shape of the issue is that after merging dev to main, dev still claims it has changes that need merged to main. I suspect it's actually a basic git thing that I just don't understand yet 🙏🏻

@ChrisRenfrow
Copy link
Collaborator Author

Hey @stillgreenmoss! I still haven't started working on this and realistically probably won't for a while. If anyone more familiar with Go and/or more available wants to take ownership of this please feel free.

@cceckman cceckman added the enhancement New feature or request label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants