dev: Add round-trip test for Recurser collection #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdkaplan
force-pushed
the
jdkaplan-db-tests
branch
2 times, most recently
from
09fd32d to
b7be051
Compare
jdkaplan
force-pushed
the
jdkaplan-db-tests
branch
from
b7be051 to
7f42ae5
Compare
cceckman
approved these changes
Aug 7, 2024
| version: '>= 486.0.0' | ||
| install_components: 'cloud-firestore-emulator' | ||
|
|
||
| - name: Start Firestore emulator |
There was a problem hiding this comment.
Oh, huh, jobs run in parallel by default!
Do we need to impose an order on these? Will the emulator keep running in the background even after the job is done?
If the answer is "we need to submit this and try it to see", that's fine :D
There was a problem hiding this comment.
There's already an order imposed because steps run sequentially even though their containing jobs run in parallel. (The YAML diff doesn't make this very easy to see, but I only appended to the one existing job.)
That said, I did consider splitting jobs.build and jobs.test. But go build is so fast that all it would really do is cause setup-go module-cache issues between the two jobs.
|
Looks good, just nits / questions! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be able to experiment with Pairing Bot locally, which means I'll need some way to run Firestore without also running all of Google Cloud. It turns out that there's an emulator inside of
gcloudwhich is made exactly for this purpose!The Firestore Go SDK we're using automatically supports using this via the
FIRESTORE_EMULATOR_HOSTenvironment variable.Changes
This sets up a single round-trip test to prove that this all works. I left space to add more because I'll be collecting them in the future as I learn about how Firestore works (and how we use it!).
I also made these tests run on PRs to the
devbranch. I intend to treat them as non-blocking there, but I do think it's nice to know that we've broken unit tests before deploying, even if it's just to the test bot.I also added a
dev.shscript to help me remember how to start the emulator. It uses the same variable as the SDK so something like direnv makes it "just work".