From 6aa76d355309ffbab53ab94bf94b92d4f6a65ebf Mon Sep 17 00:00:00 2001 From: Martin Rechsteiner Date: Thu, 3 Dec 2020 20:36:48 +0100 Subject: [PATCH] Make PageViewControllerDataSource/Delegate methods open The previous implementation was already using open, so we need to keep it open in order to prevent breaking existing apps that rely on this. --- Parchment/Classes/PagingViewController.swift | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Parchment/Classes/PagingViewController.swift b/Parchment/Classes/PagingViewController.swift index c5d27f13..6d06d5a7 100644 --- a/Parchment/Classes/PagingViewController.swift +++ b/Parchment/Classes/PagingViewController.swift @@ -638,7 +638,7 @@ open class PagingViewController: // MARK: PageViewControllerDataSource - public func pageViewController(_ pageViewController: PageViewController, viewControllerBeforeViewController viewController: UIViewController) -> UIViewController? { + open func pageViewController(_ pageViewController: PageViewController, viewControllerBeforeViewController viewController: UIViewController) -> UIViewController? { guard let dataSource = infiniteDataSource, let currentPagingItem = state.currentPagingItem, @@ -647,7 +647,7 @@ open class PagingViewController: return dataSource.pagingViewController(self, viewControllerFor: pagingItem) } - public func pageViewController(_ pageViewController: PageViewController, viewControllerAfterViewController viewController: UIViewController) -> UIViewController? { + open func pageViewController(_ pageViewController: PageViewController, viewControllerAfterViewController viewController: UIViewController) -> UIViewController? { guard let dataSource = infiniteDataSource, let currentPagingItem = state.currentPagingItem, @@ -658,7 +658,7 @@ open class PagingViewController: // MARK: PageViewControllerDelegate - public func pageViewController(_ pageViewController: PageViewController, isScrollingFrom startingViewController: UIViewController, destinationViewController: UIViewController?, progress: CGFloat) { + open func pageViewController(_ pageViewController: PageViewController, isScrollingFrom startingViewController: UIViewController, destinationViewController: UIViewController?, progress: CGFloat) { guard let currentPagingItem = state.currentPagingItem else { return } pagingController.contentScrolled(progress: progress) @@ -671,7 +671,7 @@ open class PagingViewController: progress: progress) } - public func pageViewController(_ pageViewController: PageViewController, willStartScrollingFrom startingViewController: UIViewController, destinationViewController: UIViewController) { + open func pageViewController(_ pageViewController: PageViewController, willStartScrollingFrom startingViewController: UIViewController, destinationViewController: UIViewController) { if let upcomingPagingItem = state.upcomingPagingItem { delegate?.pagingViewController( self, @@ -681,7 +681,7 @@ open class PagingViewController: } } - public func pageViewController(_ pageViewController: PageViewController, didFinishScrollingFrom startingViewController: UIViewController, destinationViewController: UIViewController, transitionSuccessful: Bool) { + open func pageViewController(_ pageViewController: PageViewController, didFinishScrollingFrom startingViewController: UIViewController, destinationViewController: UIViewController, transitionSuccessful: Bool) { if transitionSuccessful { pagingController.contentFinishedScrolling() }