Add httpAuthentication API and rename existing to httpAuthenticationWhen

Introduce httpAuthentication(BiFunction) for automatic 401 retry, and rename the predicate-based method to httpAuthenticationWhen for clarity when custom retry conditions are needed.

Signed-off-by: raccoonback <[email protected]>

Author: raccoonback

reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClient.java

@@ -1697,21 +1697,55 @@ public final HttpClient wiretap(boolean enable) {
 	}
 
 	/**
-	 * Configure HTTP authentication for the client with custom authentication logic.
+	 * Configure HTTP authentication that retries on 401 Unauthorized responses.
 	 * <p>
 	 * This method provides a generic authentication framework that allows users to implement
 	 * their own authentication mechanisms (e.g., Negotiate/SPNEGO, OAuth, Bearer tokens, custom schemes).
-	 * The framework handles when to apply authentication, while users control how to generate
-	 * and attach authentication credentials.
+	 * The framework automatically retries requests when a 401 Unauthorized response is received.
 	 * </p>
 	 *
 	 * <p>Example - Token-based Authentication:</p>
 	 * <pre>
 	 * {@code
 	 * HttpClient client = HttpClient.create()
 	 *     .httpAuthentication(
-	 *         // Retry on 401 Unauthorized responses
-	 *         (req, res) -> res.status().code() == 401,
+	 *         // Add authentication header before request
+	 *         (req, addr) -> {
+	 *             String token = generateAuthToken(addr);
+	 *             req.header(HttpHeaderNames.AUTHORIZATION, "Bearer " + token);
+	 *             return Mono.empty();
+	 *         }
+	 *     );
+	 * }
+	 * </pre>
+	 *
+	 * @param authenticator applies authentication to the request, receives the request and remote address,
+	 *                      returns a Mono that completes when authentication is applied
+	 * @return a new {@link HttpClient}
+	 * @since 1.3.0
+	 * @see #httpAuthenticationWhen(BiPredicate, BiFunction)
+	 */
+	public final HttpClient httpAuthentication(
+			BiFunction<? super HttpClientRequest, ? super SocketAddress, ? extends Mono<Void>> authenticator) {
+		return httpAuthenticationWhen(HttpClientConfig.AUTHENTICATION_PREDICATE, authenticator);
+	}
+
+	/**
+	 * Configure HTTP authentication for the client with custom authentication logic and retry predicate.
+	 * <p>
+	 * This method provides a generic authentication framework that allows users to implement
+	 * their own authentication mechanisms (e.g., Negotiate/SPNEGO, OAuth, Bearer tokens, custom schemes).
+	 * The framework handles when to apply authentication based on the provided predicate, while users
+	 * control how to generate and attach authentication credentials.
+	 * </p>
+	 *
+	 * <p>Example - Token-based Authentication with custom retry logic:</p>
+	 * <pre>
+	 * {@code
+	 * HttpClient client = HttpClient.create()
+	 *     .httpAuthenticationWhen(
+	 *         // Custom retry predicate (e.g., retry on 401 or 403)
+	 *         (req, res) -> res.status().code() == 401 || res.status().code() == 403,
 	 *         // Add authentication header before request
 	 *         (req, addr) -> {
 	 *             String token = generateAuthToken(addr);
@@ -1729,7 +1763,7 @@ public final HttpClient wiretap(boolean enable) {
 	 * @return a new {@link HttpClient}
 	 * @since 1.3.0
 	 */
-	public final HttpClient httpAuthentication(
+	public final HttpClient httpAuthenticationWhen(
 			BiPredicate<HttpClientRequest, HttpClientResponse> predicate,
 			BiFunction<? super HttpClientRequest, ? super SocketAddress, ? extends Mono<Void>> authenticator) {
 		Objects.requireNonNull(predicate, "predicate");

reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientConfig.java

@@ -845,6 +845,9 @@ else if (metricsRecorder instanceof ContextAwareHttpClientMetricsRecorder) {
 			                                               .codeAsText())
 			                                   .matches();
 
+	static final BiPredicate<HttpClientRequest, HttpClientResponse> AUTHENTICATION_PREDICATE =
+			(req, res) -> res.status().equals(HttpResponseStatus.UNAUTHORIZED);
+
 	static final int h3 = 0b1000;
 
 	static final int h2 = 0b010;

reactor-netty-http/src/test/java/reactor/netty/http/client/HttpClientTest.java

@@ -3866,7 +3866,7 @@ void testHttpAuthenticationNoRetryWhenPredicateDoesNotMatch() {
 		HttpClient client =
 				HttpClient.create()
 				          .port(disposableServer.port())
-				          .httpAuthentication(
+				          .httpAuthenticationWhen(
 				                  // Only retry on 401, not 403
 				                  (req, res) -> res.status() == HttpResponseStatus.UNAUTHORIZED,
 				                  (req, addr) -> {
@@ -3916,7 +3916,7 @@ void testHttpAuthenticationWithMonoAuthenticator() {
 		HttpClient client =
 				HttpClient.create()
 				          .port(disposableServer.port())
-				          .httpAuthentication(
+				          .httpAuthenticationWhen(
 				                  (req, res) -> res.status() == HttpResponseStatus.UNAUTHORIZED,
 				                  (req, addr) -> {
 				                      int callNum = authCallCount.incrementAndGet();
@@ -3964,7 +3964,7 @@ void testHttpAuthenticationMultipleRequests() {
 		HttpClient client =
 				HttpClient.create()
 				          .port(disposableServer.port())
-				          .httpAuthentication(
+				          .httpAuthenticationWhen(
 				                  (req, res) -> res.status() == HttpResponseStatus.UNAUTHORIZED,
 				                  (req, addr) -> {
 				                      req.header(HttpHeaderNames.AUTHORIZATION, "Bearer valid-token");
@@ -4015,7 +4015,7 @@ void testHttpAuthenticationWithCustomStatusCode() {
 		HttpClient client =
 				HttpClient.create()
 				          .port(disposableServer.port())
-				          .httpAuthentication(
+				          .httpAuthenticationWhen(
 				                  // Retry on 407 instead of 401
 				                  (req, res) -> res.status() == HttpResponseStatus.PROXY_AUTHENTICATION_REQUIRED,
 				                  (req, addr) -> {