Skip to content

Commit 91e1a67

Browse files
ingrodiasbruno
authored andcommittedJun 15, 2017
Remove deprecation warning in react 15.6.0 about React.DOM.noscript
1 parent 937f835 commit 91e1a67

File tree

5 files changed

+13
-7
lines changed

5 files changed

+13
-7
lines changed
 

Diff for: ‎examples/basic/app.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
var React = require('react');
22
var ReactDOM = require('react-dom');
33
var Modal = require('../../lib/index');
4+
var createReactClass = require('create-react-class');
45

56
var appElement = document.getElementById('example');
67

78
Modal.setAppElement('#example');
89

9-
var App = React.createClass({
10+
var App = createReactClass({
1011

1112
getInitialState: function() {
1213
return { modalIsOpen: false, modal2: false };

Diff for: ‎lib/components/Modal.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
var React = require('react');
22
var ReactDOM = require('react-dom');
3+
var DOMFactories = require('react-dom-factories');
34
var PropTypes = require('prop-types');
45
var ExecutionEnvironment = require('exenv');
56
var ModalPortal = React.createFactory(require('./ModalPortal'));
@@ -8,7 +9,7 @@ var refCount = require('../helpers/refCount');
89
var elementClass = require('element-class');
910
var renderSubtreeIntoContainer = require("react-dom").unstable_renderSubtreeIntoContainer;
1011
var Assign = require('lodash.assign');
11-
var createReactClass = require('create-react-class')
12+
var createReactClass = require('create-react-class');
1213

1314
var SafeHTMLElement = ExecutionEnvironment.canUseDOM ? window.HTMLElement : {};
1415
var AppElement = ExecutionEnvironment.canUseDOM ? document.body : {appendChild: function() {}};
@@ -145,7 +146,7 @@ var Modal = createReactClass({
145146
},
146147

147148
render: function () {
148-
return React.DOM.noscript();
149+
return DOMFactories.noscript();
149150
}
150151
});
151152

Diff for: ‎lib/components/ModalPortal.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
var React = require('react');
2-
var div = React.DOM.div;
2+
var DOMFactories = require('react-dom-factories');
33
var focusManager = require('../helpers/focusManager');
44
var scopeTab = require('../helpers/scopeTab');
55
var Assign = require('lodash.assign');
66
var createReactClass = require('create-react-class');
77

8+
var div = DOMFactories.div;
9+
810
// so that our CSS is statically analyzable
911
var CLASS_NAMES = {
1012
overlay: 'ReactModal__Overlay',

Diff for: ‎package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@
5353
"element-class": "^0.2.0",
5454
"exenv": "1.2.0",
5555
"lodash.assign": "^4.2.0",
56-
"prop-types": "^15.5.7"
56+
"prop-types": "^15.5.7",
57+
"react-dom-factories": "^1.0.0"
5758
},
5859
"peerDependencies": {
5960
"react": "^0.14.0 || ^15.0.0",

Diff for: ‎specs/Modal.spec.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import React, { Component } from 'react';
55
import ReactDOM from 'react-dom';
66
import TestUtils from 'react-addons-test-utils';
77
import Modal from '../lib/components/Modal';
8+
import createReactClass from 'create-react-class';
89
import * as ariaAppHider from '../lib/helpers/ariaAppHider';
910
import {
1011
isBodyWithReactModalOpenClass, findDOMWithClass,
@@ -62,7 +63,7 @@ describe('State', () => {
6263

6364
it('renders into the body, not in context', () => {
6465
var node = document.createElement('div');
65-
var App = React.createClass({
66+
var App = createReactClass({
6667
render() {
6768
return (
6869
<div>
@@ -346,7 +347,7 @@ describe('State', () => {
346347
var node = document.createElement('div');
347348
var modal = null;
348349

349-
var App = React.createClass({
350+
var App = createReactClass({
350351
getInitialState: function () {
351352
return { testHasChanged: false };
352353
},

0 commit comments

Comments
 (0)
Please sign in to comment.