[fixed] onAfterClose prop falsly called on unmount

Author: gados3

.gitignore

@@ -5,6 +5,7 @@ scripts/__pycache__/
 examples/**/*-bundle.js
 node_modules/
 .idea/
+.vscode
 _book
 *.patch
 *.diff

specs/Modal.events.spec.js

@@ -12,7 +12,8 @@ import {
   escKeyDown,
   tabKeyDown,
   renderModal,
-  emptyDOM
+  emptyDOM,
+  unmountModal
 } from "./helper";
 
 export default () => {
@@ -36,6 +37,20 @@ export default () => {
     onAfterCloseCallback.called.should.be.ok();
   });
 
+  it("should not trigger onAfterClose callback when unmounting a closed modal", () => {
+    const onAfterCloseCallback = sinon.spy();
+    renderModal({ isOpen: false, onAfterClose: onAfterCloseCallback });
+    unmountModal();
+    onAfterCloseCallback.called.should.not.be.ok();
+  });
+
+  it("should trigger onAfterClose callback when unmounting an opened modal", () => {
+    const onAfterCloseCallback = sinon.spy();
+    renderModal({ isOpen: true, onAfterClose: onAfterCloseCallback });
+    unmountModal();
+    onAfterCloseCallback.called.should.be.ok();
+  });
+
   it("keeps focus inside the modal when child has no tabbable elements", () => {
     let tabPrevented = false;
     const modal = renderModal({ isOpen: true }, "hello");

src/components/ModalPortal.js

@@ -114,7 +114,9 @@ export default class ModalPortal extends Component {
   }
 
   componentWillUnmount() {
-    this.afterClose();
+    if (this.state.isOpen) {
+      this.afterClose();
+    }
     clearTimeout(this.closeTimer);
   }