Skip to content

Commit 7da6ec8

Browse files
Andrew Fullerdiasbruno
Andrew Fuller
authored andcommitted
[fix] Unnecessary renders when modal is closed
1 parent 648cc2f commit 7da6ec8

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/components/Modal.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,12 @@ export default class Modal extends Component {
108108
}
109109

110110
componentWillReceiveProps(newProps) {
111-
if (newProps.isOpen) refCount.add(this);
112-
if (!newProps.isOpen) refCount.remove(this);
111+
const { isOpen } = newProps;
112+
// Stop unnecessary renders if modal is remaining closed
113+
if (!this.props.isOpen && !isOpen) return;
114+
115+
if (isOpen) refCount.add(this);
116+
if (!isOpen) refCount.remove(this);
113117
const currentParent = getParentElement(this.props.parentSelector);
114118
const newParent = getParentElement(newProps.parentSelector);
115119

0 commit comments

Comments
 (0)