Skip to content

Commit 78fa9bd

Browse files
committedOct 18, 2015
fix a couple typos
1 parent acdcb7c commit 78fa9bd

File tree

5 files changed

+13
-14
lines changed

5 files changed

+13
-14
lines changed
 

‎CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
v0.5.0 - Tue, 22 Sep 2015 19:19:44 GMT
22
--------------------------------------
33

4-
- [4d25989](../../commit/4d25989) [added] Inline CSS for modal and overlay as well as props to override. [changed] injectCSS has been changed to a warning message in preperation for a future removal. lib/components/Modal.js [changed] setAppElement method is now optional. Defaults to document.body and now allows for a css selector to be passed in rather than the whole element.
4+
- [4d25989](../../commit/4d25989) [added] Inline CSS for modal and overlay as well as props to override. [changed] injectCSS has been changed to a warning message in preparation for a future removal. lib/components/Modal.js [changed] setAppElement method is now optional. Defaults to document.body and now allows for a css selector to be passed in rather than the whole element.
55
- [02cf2c3](../../commit/02cf2c3) [fixed] Clear the closeWithTimeout timer before unmounting
66

77

‎lib/components/Modal.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ var Modal = module.exports = React.createClass({
1212
displayName: 'Modal',
1313
statics: {
1414
setAppElement: ariaAppHider.setElement,
15-
injectCSS : function() {
15+
injectCSS: function() {
1616
"production" !== process.env.NODE_ENV
1717
&& console.warn('React-Modal: injectCSS has been deprecated ' +
1818
'and no longer has any effect. It will be removed in a later version');
@@ -21,7 +21,7 @@ var Modal = module.exports = React.createClass({
2121

2222
propTypes: {
2323
isOpen: React.PropTypes.bool.isRequired,
24-
style : React.PropTypes.shape({
24+
style: React.PropTypes.shape({
2525
content: React.PropTypes.object,
2626
overlay: React.PropTypes.object
2727
}),

‎lib/components/ModalPortal.js

+5-6
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,15 @@ var CLASS_NAMES = {
2020
};
2121

2222
var defaultStyles = {
23-
overlay : {
23+
overlay: {
2424
position : 'fixed',
2525
top : 0,
2626
left : 0,
2727
right : 0,
2828
bottom : 0,
2929
backgroundColor : 'rgba(255, 255, 255, 0.75)'
3030
},
31-
content : {
31+
content: {
3232
position : 'absolute',
3333
top : '40px',
3434
left : '40px',
@@ -41,7 +41,6 @@ var defaultStyles = {
4141
borderRadius : '4px',
4242
outline : 'none',
4343
padding : '20px'
44-
4544
}
4645
};
4746

@@ -56,10 +55,10 @@ var ModalPortal = module.exports = React.createClass({
5655
getDefaultProps: function() {
5756
return {
5857
style: {
59-
overlay : {},
60-
content : {}
58+
overlay: {},
59+
content: {}
6160
}
62-
}
61+
};
6362
},
6463

6564
getInitialState: function() {

‎lib/helpers/focusManager.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ function handleFocus(event) {
1515
}
1616
// need to see how jQuery shims document.on('focusin') so we don't need the
1717
// setTimeout, firefox doesn't support focusin, if it did, we could focus
18-
// the the element outisde of a setTimeout. Side-effect of this
19-
// implementation is that the document.body gets focus, and then we focus
20-
// our element right after, seems fine.
18+
// the element outside of a setTimeout. Side-effect of this implementation
19+
// is that the document.body gets focus, and then we focus our element right
20+
// after, seems fine.
2121
setTimeout(function() {
2222
if (modalElement.contains(document.activeElement))
2323
return;

‎specs/Modal.spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ describe('Modal', function () {
109109
equal(modal.portal.refs.content.style.width, '20px');
110110
});
111111

112-
it('supports overridding style on the modal contents', function() {
112+
it('supports overriding style on the modal contents', function() {
113113
var modal = renderModal({isOpen: true, style: {content: {position: 'static'}}});
114114
equal(modal.portal.refs.content.style.position, 'static');
115115
});
@@ -119,7 +119,7 @@ describe('Modal', function () {
119119
equal(modal.portal.refs.overlay.style.width, '75px');
120120
});
121121

122-
it('supports overridding style on the modal overlay', function() {
122+
it('supports overriding style on the modal overlay', function() {
123123
var modal = renderModal({isOpen: true, style: {overlay: {position: 'static'}}});
124124
equal(modal.portal.refs.overlay.style.position, 'static');
125125
});

0 commit comments

Comments
 (0)