[fixed] Cancel requested animation frame on unmount.

adriantrunzo · diasbruno · commit 0847049f19ea · 2021-06-05T20:09:53.000-03:00
diff --git a/src/components/ModalPortal.js b/src/components/ModalPortal.js
@@ -131,6 +131,7 @@ export default class ModalPortal extends Component {
       this.afterClose();
     }
     clearTimeout(this.closeTimer);
+    cancelAnimationFrame(this.openAnimationFrame);
   }
 
   setOverlayRef = overlay => {
@@ -222,7 +223,7 @@ export default class ModalPortal extends Component {
       }
 
       this.setState({ isOpen: true }, () => {
-        requestAnimationFrame(() => {
+        this.openAnimationFrame = requestAnimationFrame(() => {
           this.setState({ afterOpen: true });
 
           if (this.props.isOpen && this.props.onAfterOpen) {

Original file line number	Diff line number	Diff line change
`@@ -131,6 +131,7 @@ export default class ModalPortal extends Component {`
`131`	`131`	`this.afterClose();`
`132`	`132`	`}`
`133`	`133`	`clearTimeout(this.closeTimer);`
	`134`	`+ cancelAnimationFrame(this.openAnimationFrame);`
`134`	`135`	`}`
`135`	`136`
`136`	`137`	`setOverlayRef = overlay => {`
`@@ -222,7 +223,7 @@ export default class ModalPortal extends Component {`
`222`	`223`	`}`
`223`	`224`
`224`	`225`	`this.setState({ isOpen: true }, () => {`
`225`		`- requestAnimationFrame(() => {`
	`226`	`+ this.openAnimationFrame = requestAnimationFrame(() => {`
`226`	`227`	`this.setState({ afterOpen: true });`
`227`	`228`
`228`	`229`	`if (this.props.isOpen && this.props.onAfterOpen) {`