Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] make the ChoiceData record public #4

Open
serrafrank opened this issue May 16, 2023 · 4 comments
Open

[FR] make the ChoiceData record public #4

serrafrank opened this issue May 16, 2023 · 4 comments
Assignees

Comments

@serrafrank
Copy link

Is your feature request related to a problem? Please describe.
the record io.github.reactiveclown.openaiwebfluxclient.client.chat.ChoiceData.java is not directly accessible..

'io.github.reactiveclown.openaiwebfluxclient.client.chat.ChoiceData' is not public in 'io.github.reactiveclown.openaiwebfluxclient.client.chat'. Cannot be accessed from outside package

Describe the solution you'd like
You should add the public keyword

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@reactiveclown
Copy link
Owner

Hi @serrafrank thank you for oppening this issue and using my library.
I will take a look on this FR tomorrow and will keep you updated.

@OpenSource03
Copy link
Contributor

Hi @reactiveclown, any updates on this? The library seems unusable without this being public...

@OpenSource03
Copy link
Contributor

I've opened a pull request that should fix this issue :)

@WernerWertitsch
Copy link

Hi, I am very sorry to bother you, but in the Version @mavencentral 0.9.1 this issue still persists (which is interesting because the Github Version 0.9.1 does have that fixed. But when trying to build/install the latest v0.9.1 from github locally I run into a problem with the gpg signing which I havent yet figured yet (I use Windows).
Do you have any tips for me? Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants