Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofilling the address form does not autofill the region #297

Open
spencern opened this issue Sep 21, 2018 · 4 comments
Open

Autofilling the address form does not autofill the region #297

spencern opened this issue Sep 21, 2018 · 4 comments
Labels
bug For issues that describe a defect or regression in the released software

Comments

@spencern
Copy link
Contributor

Type: minor

Describe the bug
Autofilling the address form does not autofill the region

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Address Form component in the component library
  2. Scroll down to an example which dynamically loads a set of countries and regions dynamically
  3. Start to enter an address you have saved in your browser such that it will autofill
  4. See that the region is not autofilled

Expected behavior
The Region should be autofilled even if the set of regions are dynamically loaded

Screenshots
image

@spencern spencern added the bug For issues that describe a defect or regression in the released software label Sep 21, 2018
@aldeed
Copy link
Contributor

aldeed commented Sep 21, 2018

Most likely this is an issue with react-select, but could also be that we're not tagging the region field properly for autofill to know what it is.

@aldeed aldeed added this to the North Maroon milestone Sep 21, 2018
@spencern
Copy link
Contributor Author

spencern commented Sep 21, 2018

I don't see this as a blocker, but we should figure it out at some point because it's pretty annoying

@nnnnat nnnnat self-assigned this Sep 25, 2018
@nnnnat
Copy link
Contributor

nnnnat commented Sep 26, 2018

After trying a few things and doing some research I beleive this might be coming from react-select.
react-select uses a hidden HTML <input /> to capture the actual value and it seems that some browser autofills can't see that input, looks like react-select has an open PR that may address this issue but they're a little out of date.

@spencern spencern removed this from the North Maroon milestone Oct 2, 2018
@spencern
Copy link
Contributor Author

spencern commented Oct 2, 2018

Moving this to the icebox as it's low priority. It looks like react-select may be abandoned at this point based on the amount of time that JedWatson/react-select#2174 and JedWatson/react-select#2395 have been open.

Open to other ideas for how to resolve this issue

@nnnnat nnnnat removed their assignment Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Development

No branches or pull requests

3 participants