Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Follow-up to #59878, as asked in review: add tests that check that when
jsLocationhas no port, Configure Bundler does not fall back to the port of the bundle URL.RCTDevMenuGetCurrentBundlernow takes the bundle URL,jsLocation, packager scheme andip.txtcontents as arguments instead of reading them itself, and is exposed inRCTDevMenu.hfor testing. The call site reads them as before, so behavior does not change.RCTDevMenuTestscovers each source of the host and port: bundle URL,jsLocation(with and without a scheme, IPv6),ip.txt, and the localhost default.Changelog:
[Internal]
Test Plan:
xcodebuild test -workspace RNTesterPods.xcworkspace -scheme RNTester -only-testing:RNTesterUnitTests/RCTDevMenuTestson an iOS 26.2 simulator: 8 tests pass.