Repository navigation
Commit 7564317
authored
[visual testing] Make the platform checks neutral on differences
The `Visual regression (android)` and `(ios)` checks fail on any difference, and applying `visual-change-approved` only passes the `Visual regression approval` gate, so an approved PR still shows two red checks - eg #59787, where both platforms only differ by the new test it adds.
This makes the platform checks neutral when there are differences, so the gate is the only visual check that fails, and only until the differences are approved. None of the visual checks are required, and a neutral check doesn't fail a PR's overall status. Removing the label, or a push that changes the differences, fails the gate again as before.
Changelog: [Internal]
Test plan:
New unit test. Also ran the compare step's `report` against #59787's real report with the GitHub API mocked: both platform checks post `neutral`, and the gate posts `failure` without the label and `success` ("approved by @javache") with it.
Differential Revision: D132905555
Pull Request resolved: #601101 parent f4f8b6a commit 7564317
3 files changed
Lines changed: 30 additions & 9 deletions
File tree
- .github/workflow-scripts
- __tests__
- visual
- packages/rn-tester/visual-tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
389 | 390 | | |
390 | 391 | | |
391 | 392 | | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
392 | 403 | | |
393 | 404 | | |
394 | 405 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
367 | 367 | | |
368 | 368 | | |
369 | 369 | | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
370 | 381 | | |
371 | 382 | | |
372 | 383 | | |
| |||
402 | 413 | | |
403 | 414 | | |
404 | 415 | | |
405 | | - | |
406 | 416 | | |
407 | 417 | | |
408 | 418 | | |
409 | | - | |
410 | | - | |
411 | | - | |
412 | | - | |
413 | | - | |
414 | | - | |
| 419 | + | |
415 | 420 | | |
416 | 421 | | |
417 | 422 | | |
| |||
511 | 516 | | |
512 | 517 | | |
513 | 518 | | |
514 | | - | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
0 commit comments