Skip to content

Commit 53e3cc9

Browse files
committed
Add text variant of maybeStoreResponseBody to RCTInspectorNetworkReporter
1 parent 094d072 commit 53e3cc9

6 files changed

Lines changed: 23 additions & 0 deletions

File tree

‎packages/react-native/Libraries/Network/RCTInspectorNetworkReporter.h‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,13 @@
8686
*/
8787
+ (void)maybeStoreResponseBody:(NSString *)requestId data:(NSData *)data base64Encoded:(bool)base64Encoded;
8888

89+
/**
90+
* Store a decoded text response body preview. As with
91+
* `maybeStoreResponseBody:data:base64Encoded:`, this is a no-op if CDP
92+
* debugging is disabled.
93+
*/
94+
+ (void)maybeStoreResponseBody:(NSString *)requestId text:(NSString *)text;
95+
8996
/**
9097
* Incrementally store a response body preview, when a string response is
9198
* received in chunks. Buffered contents will be flushed to `NetworkReporter`

‎packages/react-native/Libraries/Network/RCTInspectorNetworkReporter.mm‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,18 @@ + (void)maybeStoreResponseBody:(NSString *)requestId data:(id)data base64Encoded
193193
#endif
194194
}
195195

196+
+ (void)maybeStoreResponseBody:(NSString *)requestId text:(NSString *)text
197+
{
198+
#ifdef REACT_NATIVE_DEBUGGER_ENABLED
199+
auto &networkReporter = NetworkReporter::getInstance();
200+
if (!networkReporter.isDebuggingEnabled() || text.length == 0) {
201+
return;
202+
}
203+
204+
networkReporter.storeResponseBody(requestId.UTF8String, RCTStringViewFromNSString(text), false);
205+
#endif
206+
}
207+
196208
+ (void)maybeStoreResponseBodyIncremental:(NSString *)requestId data:(NSString *)data
197209
{
198210
#ifdef REACT_NATIVE_DEBUGGER_ENABLED

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1189,6 +1189,7 @@ interface RCTInspectorNetworkHelper : public NSObject {
11891189

11901190
interface RCTInspectorNetworkReporter : public NSObject {
11911191
public virtual static void maybeStoreResponseBody:data:base64Encoded:(NSString* requestId, NSData* data, bool base64Encoded);
1192+
public virtual static void maybeStoreResponseBody:text:(NSString* requestId, NSString* text);
11921193
public virtual static void maybeStoreResponseBodyIncremental:data:(NSString* requestId, NSString* data);
11931194
public virtual static void reportConnectionTiming:request:(NSString* requestId, NSURLRequest* request);
11941195
public virtual static void reportDataReceived:data:(NSString* requestId, NSData* data);

‎scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1212,6 +1212,7 @@ interface RCTInspectorNetworkHelper : public NSObject {
12121212

12131213
interface RCTInspectorNetworkReporter : public NSObject {
12141214
public virtual static void maybeStoreResponseBody:data:base64Encoded:(NSString* requestId, NSData* data, bool base64Encoded);
1215+
public virtual static void maybeStoreResponseBody:text:(NSString* requestId, NSString* text);
12151216
public virtual static void maybeStoreResponseBodyIncremental:data:(NSString* requestId, NSString* data);
12161217
public virtual static void reportConnectionTiming:request:(NSString* requestId, NSURLRequest* request);
12171218
public virtual static void reportDataReceived:data:(NSString* requestId, NSData* data);

‎scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1189,6 +1189,7 @@ interface RCTInspectorNetworkHelper : public NSObject {
11891189

11901190
interface RCTInspectorNetworkReporter : public NSObject {
11911191
public virtual static void maybeStoreResponseBody:data:base64Encoded:(NSString* requestId, NSData* data, bool base64Encoded);
1192+
public virtual static void maybeStoreResponseBody:text:(NSString* requestId, NSString* text);
11921193
public virtual static void maybeStoreResponseBodyIncremental:data:(NSString* requestId, NSString* data);
11931194
public virtual static void reportConnectionTiming:request:(NSString* requestId, NSURLRequest* request);
11941195
public virtual static void reportDataReceived:data:(NSString* requestId, NSData* data);

‎scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1189,6 +1189,7 @@ interface RCTInspectorNetworkHelper : public NSObject {
11891189

11901190
interface RCTInspectorNetworkReporter : public NSObject {
11911191
public virtual static void maybeStoreResponseBody:data:base64Encoded:(NSString* requestId, NSData* data, bool base64Encoded);
1192+
public virtual static void maybeStoreResponseBody:text:(NSString* requestId, NSString* text);
11921193
public virtual static void maybeStoreResponseBodyIncremental:data:(NSString* requestId, NSString* data);
11931194
public virtual static void reportConnectionTiming:request:(NSString* requestId, NSURLRequest* request);
11941195
public virtual static void reportDataReceived:data:(NSString* requestId, NSData* data);

0 commit comments

Comments
 (0)