Skip to content

Commit 532d1ca

Browse files
authored
[LOCAL] Bump Metro to 0.88.0 (#59875)
Picks #59831 to 0.89.
1 parent 2f9082f commit 532d1ca

9 files changed

Lines changed: 166 additions & 116 deletions

File tree

‎package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,8 @@
113113
"markdownlint-cli2": "^0.23.3",
114114
"markdownlint-rule-relative-links": "^5.1.4",
115115
"memfs": "^4.38.2",
116-
"metro-babel-register": "^0.87.2",
117-
"metro-transform-plugins": "^0.87.2",
116+
"metro-babel-register": "^0.88.0",
117+
"metro-transform-plugins": "^0.88.0",
118118
"micromatch": "^4.0.4",
119119
"node-fetch": "^2.2.0",
120120
"nullthrows": "^1.1.1",

‎packages/community-cli-plugin/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@
3737
"commander": "^12.0.0",
3838
"debug": "^4.4.0",
3939
"invariant": "^2.2.4",
40-
"metro": "^0.87.2",
40+
"metro": "^0.88.0",
4141
"semver": "^7.1.3"
4242
},
4343
"devDependencies": {
44-
"metro-resolver": "^0.87.2"
44+
"metro-resolver": "^0.88.0"
4545
},
4646
"peerDependencies": {
4747
"@react-native-community/cli": "*",

‎packages/metro-config/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,6 @@
3838
"dependencies": {
3939
"@react-native/js-polyfills": "0.89.0-rc.0",
4040
"@react-native/metro-babel-transformer": "0.89.0-rc.0",
41-
"metro-config": "^0.87.2"
41+
"metro-config": "^0.88.0"
4242
}
4343
}

‎packages/metro-config/src/index.flow.js‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,7 @@ export function getDefaultConfig(projectRoot: string): ConfigT {
6464
},
6565
},
6666
transformer: {
67-
allowOptionalDependencies: true,
6867
assetRegistryPath: 'react-native/asset-registry',
69-
asyncRequireModulePath: 'metro:runtime/modules/asyncRequire',
7068
babelTransformerPath:
7169
require.resolve('@react-native/metro-babel-transformer'),
7270
getTransformOptions: async () => ({
@@ -76,7 +74,6 @@ export function getDefaultConfig(projectRoot: string): ConfigT {
7674
},
7775
}),
7876
},
79-
watchFolders: [],
8077
};
8178

8279
const metroDefaults = getBaseConfig.getDefaultValues(projectRoot);
Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow strict-local
8+
* @format
9+
*/
10+
11+
'use strict';
12+
13+
const path = require('node:path');
14+
15+
const PROJECT_ROOT = path.sep === '/' ? '/my/project' : 'C:\\my\\project';
16+
17+
// The transformer memoizes its resolved Babel config in a module-level
18+
// closure, so a fresh module instance is required for every distinct config.
19+
beforeEach(() => {
20+
jest.resetModules();
21+
});
22+
23+
function getCallerSupportsInlineModules(
24+
supportsInlineModules: ?boolean,
25+
): unknown {
26+
const {transform} = require('../index.js');
27+
let callerValue: unknown = null;
28+
transform({
29+
filename: path.join(PROJECT_ROOT, 'App.js'),
30+
src: 'export const foo = 1;',
31+
plugins: [
32+
api => {
33+
callerValue = api.caller(caller => caller?.supportsInlineModules);
34+
return {visitor: {}};
35+
},
36+
],
37+
options: {
38+
...(supportsInlineModules != null ? {supportsInlineModules} : null),
39+
dev: true,
40+
enableBabelRuntime: false,
41+
enableBabelRCLookup: false,
42+
globalPrefix: '__metro__',
43+
minify: false,
44+
platform: 'ios',
45+
publicPath: 'test',
46+
projectRoot: PROJECT_ROOT,
47+
},
48+
});
49+
return callerValue;
50+
}
51+
52+
test.each([[true], [false], [undefined]])(
53+
'passes supportsInlineModules: %s to Babel through the caller',
54+
supportsInlineModules => {
55+
expect(getCallerSupportsInlineModules(supportsInlineModules)).toBe(
56+
supportsInlineModules,
57+
);
58+
},
59+
);

‎packages/react-native-babel-transformer/src/index.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,6 @@ const transform /*: BabelTransformer['transform'] */ = ({
199199
src,
200200
plugins,
201201
}) => {
202-
// $FlowFixMe[prop-missing] Remove suppression after next Metro release
203202
const {babelRuntimeModuleName, babelRuntimeVersion} = options;
204203
const babelConfig /*: BabelCoreOptions */ = {
205204
// ES modules require sourceType='module' but OSS may not always want that
@@ -211,7 +210,6 @@ const transform /*: BabelTransformer['transform'] */ = ({
211210
name: 'metro',
212211
bundler: 'metro',
213212
platform: options.platform,
214-
// $FlowFixMe[prop-missing] Remove suppression after next Metro release
215213
inlinePlatform: options.inlinePlatform,
216214
experimentalImportSupport: options.experimentalImportSupport,
217215
unstable_transformProfile: options.unstable_transformProfile,
@@ -220,6 +218,8 @@ const transform /*: BabelTransformer['transform'] */ = ({
220218
...(babelRuntimeModuleName != null && babelRuntimeVersion != null
221219
? {babelRuntimeModuleName, enableBabelRuntime: babelRuntimeVersion}
222220
: null),
221+
// Whether `metro:inline` specifiers will resolve.
222+
supportsInlineModules: options.supportsInlineModules,
223223
},
224224
ast: true,
225225

‎packages/react-native/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,8 @@
164164
"hermes-compiler": "260318099.0.7",
165165
"invariant": "^2.2.4",
166166
"memoize-one": "^6.0.0",
167-
"metro-runtime": "^0.87.2",
168-
"metro-source-map": "^0.87.2",
167+
"metro-runtime": "^0.88.0",
168+
"metro-source-map": "^0.88.0",
169169
"nullthrows": "^1.1.1",
170170
"pretty-format": "^29.7.0",
171171
"promise": "^8.3.0",

‎private/core-cli-utils/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"./version.js": "./src/public/version.js"
1212
},
1313
"dependencies": {
14-
"metro-babel-register": "^0.87.2"
14+
"metro-babel-register": "^0.88.0"
1515
},
1616
"devDependencies": {},
1717
"engines": {

0 commit comments

Comments
 (0)