Skip to content

Commit 49bde6d

Browse files
committed
Add text variant of maybeStoreResponseBody to RCTInspectorNetworkReporter
1 parent 7b6e790 commit 49bde6d

6 files changed

Lines changed: 23 additions & 0 deletions

File tree

‎packages/react-native/Libraries/Network/RCTInspectorNetworkReporter.h‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,13 @@
8686
*/
8787
+ (void)maybeStoreResponseBody:(NSString *)requestId data:(NSData *)data base64Encoded:(bool)base64Encoded;
8888

89+
/**
90+
* Store a decoded text response body preview. As with
91+
* `maybeStoreResponseBody:data:base64Encoded:`, this is a no-op if CDP
92+
* debugging is disabled.
93+
*/
94+
+ (void)maybeStoreResponseBody:(NSString *)requestId body:(NSString *)body;
95+
8996
/**
9097
* Incrementally store a response body preview, when a string response is
9198
* received in chunks. Buffered contents will be flushed to `NetworkReporter`

‎packages/react-native/Libraries/Network/RCTInspectorNetworkReporter.mm‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,18 @@ + (void)maybeStoreResponseBody:(NSString *)requestId data:(id)data base64Encoded
187187
#endif
188188
}
189189

190+
+ (void)maybeStoreResponseBody:(NSString *)requestId body:(NSString *)body
191+
{
192+
#ifdef REACT_NATIVE_DEBUGGER_ENABLED
193+
auto &networkReporter = NetworkReporter::getInstance();
194+
if (!networkReporter.isDebuggingEnabled() || body.length == 0) {
195+
return;
196+
}
197+
198+
networkReporter.storeResponseBody(requestId.UTF8String, RCTStringViewFromNSString(body), false);
199+
#endif
200+
}
201+
190202
+ (void)maybeStoreResponseBodyIncremental:(NSString *)requestId data:(NSString *)data
191203
{
192204
#ifdef REACT_NATIVE_DEBUGGER_ENABLED

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1188,6 +1188,7 @@ interface RCTInspectorNetworkHelper : public NSObject {
11881188
}
11891189

11901190
interface RCTInspectorNetworkReporter : public NSObject {
1191+
public virtual static void maybeStoreResponseBody:body:(NSString* requestId, NSString* body);
11911192
public virtual static void maybeStoreResponseBody:data:base64Encoded:(NSString* requestId, NSData* data, bool base64Encoded);
11921193
public virtual static void maybeStoreResponseBodyIncremental:data:(NSString* requestId, NSString* data);
11931194
public virtual static void reportConnectionTiming:request:(NSString* requestId, NSURLRequest* request);

‎scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1211,6 +1211,7 @@ interface RCTInspectorNetworkHelper : public NSObject {
12111211
}
12121212

12131213
interface RCTInspectorNetworkReporter : public NSObject {
1214+
public virtual static void maybeStoreResponseBody:body:(NSString* requestId, NSString* body);
12141215
public virtual static void maybeStoreResponseBody:data:base64Encoded:(NSString* requestId, NSData* data, bool base64Encoded);
12151216
public virtual static void maybeStoreResponseBodyIncremental:data:(NSString* requestId, NSString* data);
12161217
public virtual static void reportConnectionTiming:request:(NSString* requestId, NSURLRequest* request);

‎scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1188,6 +1188,7 @@ interface RCTInspectorNetworkHelper : public NSObject {
11881188
}
11891189

11901190
interface RCTInspectorNetworkReporter : public NSObject {
1191+
public virtual static void maybeStoreResponseBody:body:(NSString* requestId, NSString* body);
11911192
public virtual static void maybeStoreResponseBody:data:base64Encoded:(NSString* requestId, NSData* data, bool base64Encoded);
11921193
public virtual static void maybeStoreResponseBodyIncremental:data:(NSString* requestId, NSString* data);
11931194
public virtual static void reportConnectionTiming:request:(NSString* requestId, NSURLRequest* request);

‎scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1188,6 +1188,7 @@ interface RCTInspectorNetworkHelper : public NSObject {
11881188
}
11891189

11901190
interface RCTInspectorNetworkReporter : public NSObject {
1191+
public virtual static void maybeStoreResponseBody:body:(NSString* requestId, NSString* body);
11911192
public virtual static void maybeStoreResponseBody:data:base64Encoded:(NSString* requestId, NSData* data, bool base64Encoded);
11921193
public virtual static void maybeStoreResponseBodyIncremental:data:(NSString* requestId, NSString* data);
11931194
public virtual static void reportConnectionTiming:request:(NSString* requestId, NSURLRequest* request);

0 commit comments

Comments
 (0)