Skip to content

Commit 487979a

Browse files
authored
Update the Fantom FAQ to say tests run on GitHub CI
## Summary: The Fantom README FAQ says the tests don't run outside Meta's CI, but Test All already builds the Fantom runner and runs the suite in GitHub Actions (`build_fantom_runner` and `run_fantom_tests`) on every PR that changes code. This updates the answer to match. Fixes #60028 ## Changelog: [INTERNAL] [CHANGED] - Update the Fantom README FAQ to say tests run on GitHub CI ## Test Plan: Docs only. Checked the wording against `.github/workflows/test-all.yml` and the Fantom jobs in the Test All run of #60023, and confirmed the relative link to the workflow file resolves. Differential Revision: D132275666 Pull Request resolved: #60031
1 parent fd3fa3c commit 487979a

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

  • private/react-native-fantom/__docs__

‎private/react-native-fantom/__docs__/README.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -661,9 +661,9 @@ has simple examples you can learn from.
661661

662662
#### Are tests executed on Github CI?
663663

664-
Fantom tests are currently tied to Meta's infrastructure and do not run outside
665-
of Meta's CI. We are working on migrating Fantom to Github CI. If you submit a
666-
PR, the tests will run as part of the PR import process.
664+
Yes. The [Test All](../../../.github/workflows/test-all.yml) workflow builds the
665+
Fantom runner and runs the tests on GitHub Actions for every PR that changes
666+
code. The tests also run as part of the PR import process.
667667

668668
#### Can I gate individual tests within a suite to only run, or not run, with a specific feature flag?
669669

0 commit comments

Comments
 (0)