Skip to content

Commit 076d7f5

Browse files
Fix: Allow users to override usesCleartextTraffic in build.gradle manifestPlaceholders
Previously, the React Native Gradle plugin always overwrote the usesCleartextTraffic manifest placeholder regardless of user configuration. This change checks if the user has already set a value before overriding it with the default. Fixes #60083
1 parent 5a14634 commit 076d7f5

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

‎packages/gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/AgpConfiguratorUtils.kt‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,19 @@ internal object AgpConfiguratorUtils {
3434
ext.buildTypes {
3535
val debug =
3636
getByName("debug").apply {
37-
manifestPlaceholders["usesCleartextTraffic"] = "true"
37+
if (!manifestPlaceholders.containsKey("usesCleartextTraffic")) {
38+
manifestPlaceholders["usesCleartextTraffic"] = "true"
39+
}
3840
}
3941
getByName("release").apply {
40-
manifestPlaceholders["usesCleartextTraffic"] = "false"
42+
if (!manifestPlaceholders.containsKey("usesCleartextTraffic")) {
43+
manifestPlaceholders["usesCleartextTraffic"] = "false"
44+
}
4145
}
4246
maybeCreate("debugOptimized").apply {
43-
manifestPlaceholders["usesCleartextTraffic"] = "true"
47+
if (!manifestPlaceholders.containsKey("usesCleartextTraffic")) {
48+
manifestPlaceholders["usesCleartextTraffic"] = "true"
49+
}
4450
initWith(debug)
4551
matchingFallbacks += listOf("release")
4652
externalNativeBuild { cmake { arguments("-DCMAKE_BUILD_TYPE=Release") } }

0 commit comments

Comments
 (0)