Repository navigation
Commit 70f0c5b
committed
CI: Test under pnpm's isolated node_modules
Yarn hoists every dependency into the root `node_modules`, so a package can import something it doesn't declare and nothing notices until a user installs it some other way. #2116 fixed the cases in our root scripts, and this makes sure we don't regress.
This adds a `test-pnpm` job to `build-test-and-deploy`. It generates `pnpm-lock.yaml` from `yarn.lock` with `pnpm import`, installs, and runs Flow, `typecheck-ts`, lint and Jest (with the same retries as the Yarn test job). It's a single Ubuntu / Node 24 job rather than another matrix - it's there to catch undeclared dependencies, not platform differences. pnpm is pinned so that `pnpm import` output doesn't drift under us.
Changelog: Internal
Test plan:
`actionlint` passes. Ran the job's steps locally against a fresh copy of this PR, with pnpm 12.21.0 (on Node 22.13 rather than 24) - all pass, including Jest (175 suites, 3475 tests).
CI on this PR runs the new job.1 parent 8e6a43f commit 70f0c5b
1 file changed
Lines changed: 34 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
68 | 102 | | |
69 | 103 | | |
70 | 104 | | |
| |||
0 commit comments