Repository navigation
Commit 08303d7
authored
metro-file-map: Let plugins report what changed in a batch, on the change event
## Context
A file map plugin often knows things about a batch of changes that nothing else can work out. For Haste, #1952 records the names a resolution looked up, and invalidating from those means knowing which names a change rebound. The `ChangeEvent` carries paths, and by the time a consumer sees it a removed file's name is already gone from the map, but `HastePlugin.onChanged` has it to hand:
https://github.com/react/metro/blob/6dbe97956af0f66f7a1d88014ba0b784a4a4d893/packages/metro-file-map/src/plugins/HastePlugin.js#L241-L245
## This change
This lets a plugin's `onChanged` return a summary, published on `ChangeEvent.pluginChanges` by plugin name. The summary type defaults to `void`, so existing plugins are unaffected. `HastePlugin` reports `changedNames`.
Plugin names now have to be unique across all plugins, not just those with a worker. Persisted state was already keyed by name, so two sharing a name were already overwriting each other.
Not addressed here: on a cold start `HastePlugin` builds a summary nobody reads (transient, and nothing where Haste is inert), and an edit that changes a file's Haste name is neither applied to the map nor reported, which predates this.
Invalidating from the summary is the next PR.
Changelog: Internal
## Test plan
New unit tests cover the watch and recrawl paths and duplicate plugin names.1 parent b51ffd3 commit 08303d7
7 files changed
Lines changed: 211 additions & 43 deletions
File tree
- packages/metro-file-map
- src
- __tests__
- lib
- plugins
- haste/__tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
| |||
209 | 210 | | |
210 | 211 | | |
211 | 212 | | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
212 | 232 | | |
213 | 233 | | |
214 | 234 | | |
| |||
227 | 247 | | |
228 | 248 | | |
229 | 249 | | |
230 | | - | |
| 250 | + | |
231 | 251 | | |
232 | 252 | | |
233 | 253 | | |
| |||
239 | 259 | | |
240 | 260 | | |
241 | 261 | | |
242 | | - | |
| 262 | + | |
243 | 263 | | |
244 | 264 | | |
245 | 265 | | |
| |||
265 | 285 | | |
266 | 286 | | |
267 | 287 | | |
268 | | - | |
| 288 | + | |
269 | 289 | | |
270 | 290 | | |
271 | 291 | | |
272 | 292 | | |
273 | | - | |
| 293 | + | |
274 | 294 | | |
275 | 295 | | |
276 | | - | |
| 296 | + | |
| 297 | + | |
277 | 298 | | |
278 | 299 | | |
279 | 300 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
312 | 312 | | |
313 | 313 | | |
314 | 314 | | |
315 | | - | |
| 315 | + | |
316 | 316 | | |
317 | 317 | | |
318 | 318 | | |
| |||
514 | 514 | | |
515 | 515 | | |
516 | 516 | | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
517 | 535 | | |
518 | 536 | | |
519 | 537 | | |
| |||
1758 | 1776 | | |
1759 | 1777 | | |
1760 | 1778 | | |
| 1779 | + | |
| 1780 | + | |
| 1781 | + | |
| 1782 | + | |
| 1783 | + | |
| 1784 | + | |
| 1785 | + | |
| 1786 | + | |
| 1787 | + | |
| 1788 | + | |
| 1789 | + | |
| 1790 | + | |
| 1791 | + | |
| 1792 | + | |
| 1793 | + | |
| 1794 | + | |
| 1795 | + | |
| 1796 | + | |
| 1797 | + | |
| 1798 | + | |
| 1799 | + | |
| 1800 | + | |
1761 | 1801 | | |
1762 | 1802 | | |
1763 | 1803 | | |
| |||
1772 | 1812 | | |
1773 | 1813 | | |
1774 | 1814 | | |
1775 | | - | |
| 1815 | + | |
1776 | 1816 | | |
1777 | 1817 | | |
1778 | 1818 | | |
| |||
1795 | 1835 | | |
1796 | 1836 | | |
1797 | 1837 | | |
1798 | | - | |
| 1838 | + | |
1799 | 1839 | | |
1800 | 1840 | | |
1801 | 1841 | | |
| |||
2635 | 2675 | | |
2636 | 2676 | | |
2637 | 2677 | | |
2638 | | - | |
| 2678 | + | |
| 2679 | + | |
| 2680 | + | |
| 2681 | + | |
| 2682 | + | |
| 2683 | + | |
2639 | 2684 | | |
2640 | 2685 | | |
2641 | 2686 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
116 | 121 | | |
117 | 122 | | |
118 | 123 | | |
| |||
302 | 307 | | |
303 | 308 | | |
304 | 309 | | |
| 310 | + | |
305 | 311 | | |
| 312 | + | |
306 | 313 | | |
307 | 314 | | |
308 | 315 | | |
309 | 316 | | |
310 | 317 | | |
311 | | - | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
312 | 323 | | |
313 | 324 | | |
314 | 325 | | |
315 | 326 | | |
316 | 327 | | |
317 | | - | |
| 328 | + | |
318 | 329 | | |
319 | 330 | | |
320 | 331 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
126 | | - | |
| 126 | + | |
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
| |||
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
| 151 | + | |
151 | 152 | | |
| 153 | + | |
152 | 154 | | |
153 | 155 | | |
154 | 156 | | |
| |||
331 | 333 | | |
332 | 334 | | |
333 | 335 | | |
| 336 | + | |
334 | 337 | | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
335 | 345 | | |
336 | 346 | | |
337 | 347 | | |
338 | 348 | | |
339 | | - | |
340 | | - | |
341 | | - | |
342 | | - | |
343 | | - | |
344 | | - | |
345 | | - | |
346 | | - | |
347 | 349 | | |
348 | 350 | | |
349 | 351 | | |
| |||
557 | 559 | | |
558 | 560 | | |
559 | 561 | | |
560 | | - | |
| 562 | + | |
| 563 | + | |
561 | 564 | | |
562 | 565 | | |
563 | 566 | | |
| |||
685 | 688 | | |
686 | 689 | | |
687 | 690 | | |
688 | | - | |
| 691 | + | |
689 | 692 | | |
690 | 693 | | |
691 | 694 | | |
| |||
697 | 700 | | |
698 | 701 | | |
699 | 702 | | |
| 703 | + | |
700 | 704 | | |
701 | 705 | | |
702 | 706 | | |
| |||
797 | 801 | | |
798 | 802 | | |
799 | 803 | | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
800 | 822 | | |
801 | 823 | | |
802 | 824 | | |
| |||
805 | 827 | | |
806 | 828 | | |
807 | 829 | | |
808 | | - | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
809 | 834 | | |
810 | 835 | | |
811 | 836 | | |
| |||
894 | 919 | | |
895 | 920 | | |
896 | 921 | | |
897 | | - | |
898 | | - | |
899 | | - | |
900 | | - | |
901 | | - | |
902 | | - | |
903 | | - | |
| 922 | + | |
904 | 923 | | |
905 | 924 | | |
906 | 925 | | |
907 | | - | |
| 926 | + | |
908 | 927 | | |
909 | 928 | | |
910 | 929 | | |
| |||
1012 | 1031 | | |
1013 | 1032 | | |
1014 | 1033 | | |
1015 | | - | |
1016 | | - | |
1017 | | - | |
1018 | | - | |
1019 | | - | |
1020 | | - | |
1021 | | - | |
| 1034 | + | |
1022 | 1035 | | |
1023 | 1036 | | |
1024 | 1037 | | |
| |||
1038 | 1051 | | |
1039 | 1052 | | |
1040 | 1053 | | |
| 1054 | + | |
1041 | 1055 | | |
1042 | 1056 | | |
1043 | 1057 | | |
| |||
1182 | 1196 | | |
1183 | 1197 | | |
1184 | 1198 | | |
1185 | | - | |
| 1199 | + | |
| 1200 | + | |
| 1201 | + | |
| 1202 | + | |
1186 | 1203 | | |
1187 | 1204 | | |
1188 | 1205 | | |
| |||
1203 | 1220 | | |
1204 | 1221 | | |
1205 | 1222 | | |
| 1223 | + | |
1206 | 1224 | | |
1207 | 1225 | | |
1208 | 1226 | | |
| |||
0 commit comments