Skip to content

Commit b3761a9

Browse files
committed
DropdownToggle: make aria-expanded optional
1 parent 44dc346 commit b3761a9

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/DropdownToggle.tsx

+4-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export interface UseDropdownToggleProps {
1010
id: string;
1111
ref: DropdownContextValue['setToggle'];
1212
onClick: React.MouseEventHandler;
13-
'aria-expanded': boolean;
13+
'aria-expanded'?: boolean | null;
1414
'aria-haspopup'?: true;
1515
}
1616

@@ -49,14 +49,16 @@ export function useDropdownToggle(): [
4949
id,
5050
ref: setToggle || noop,
5151
onClick: handleClick,
52-
'aria-expanded': !!show,
5352
};
5453

5554
// This is maybe better down in an effect, but
5655
// the component is going to update anyway when the menu element
5756
// is set so might return new props.
5857
if (menuElement && isRoleMenu(menuElement)) {
5958
props['aria-haspopup'] = true;
59+
props['aria-expanded'] = show || null;
60+
} else {
61+
props['aria-expanded'] = !!show;
6062
}
6163

6264
return [props, { show, toggle }];

0 commit comments

Comments
 (0)