Fix lint errors & improve some type declarations

Author: Sander Vispoel

src/components/common/interaction/Link.tsx

@@ -11,7 +11,7 @@ export const Link: React.FC<LinkProps> = ({
 }) => {
   const formattedAriaLabel = _.capitalize(ariaLabel);
 
-  let linkProps: React.AnchorHTMLAttributes<{}> = {
+  let linkProps: React.AnchorHTMLAttributes<Element> = {
     className: className || '',
   };
 
@@ -73,7 +73,7 @@ export const Link: React.FC<LinkProps> = ({
   );
 };
 
-type BaseProps = React.AnchorHTMLAttributes<{}> & {
+type BaseProps = React.AnchorHTMLAttributes<Element> & {
   children: React.ReactNode;
   className?: string;
   ariaLabel?: string;

src/components/pages/data.tsx

@@ -14,6 +14,8 @@ import { PrimeHeader, PrimeContent } from 'modules/Home/styled';
  * The second parameter is for typing URL queries
  */
 const Data: i.NextPageReduxComponent<DataProps, DataQueries> = ({ data, query }) => {
+  // This line here is to test Redux functionality
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   const dataLoading = useSelector((state) => state.data.loading);
 
   return (

src/types/declarations.d.ts

@@ -7,26 +7,22 @@ declare const __TEST__: boolean;
 
 // extend window object
 interface Window {
-  __REDUX_DEVTOOLS_EXTENSION__: Function;
+  __REDUX_DEVTOOLS_EXTENSION__: () => () => void;
   __NEXT_REDUX_STORE__: any;
 }
 
-declare interface NodeModule {
-  hot: {
-    accept(path?: string, callback?: () => void): void;
-  };
-}
 
 // We have to declare how files other than .ts(x) or .js(x) are handled by our codebase because
 // Typescript does not know we are handling these files with Webpack.
 declare module '*.json' {
-  const value: object;
+  type Json = string | number | boolean | { [key: string]: Json } | Json[] | null;
+  const value: Json;
   export default value;
 }
 
 // Image files
 declare module '*.svg' {
-  const value: React.ReactComponentElement;
+  const value: React.ComponentType<React.SVGProps<SVGSVGElement>>;
   export = value;
 }
 declare module '*.gif' {
@@ -46,7 +42,7 @@ declare module '*.png' {
   export = value;
 }
 
-// Image files external import
+// Image files external import are always strings
 declare module '*.svg?external' {
   const value: string;
   export = value;