fix(variables): support dot in variable names

Author: Murat

package-lock.json

@@ -56,7 +56,9 @@
     "commander": "^13.1.0",
     "glob": "^11.0.1",
     "isomorphic-fetch": "^3.0.0",
+    "lodash.get": "^4.4.2",
     "lodash.mergewith": "^4.6.2",
+    "lodash.set": "^4.3.2",
     "picocolors": "^1.1.1",
     "prettier": "^3.5.1",
     "semver": "^7.7.1",
@@ -69,7 +71,9 @@
     "@ryansonshine/commitizen": "^4.2.8",
     "@ryansonshine/cz-conventional-changelog": "^3.3.4",
     "@types/jest": "^29.5.14",
+    "@types/lodash.get": "^4.4.9",
     "@types/lodash.mergewith": "^4.6.9",
+    "@types/lodash.set": "^4.3.9",
     "@types/node": "^22.13.4",
     "@types/prettier": "^3.0.0",
     "@types/semver": "^7.5.8",

package.json

@@ -144,6 +144,7 @@ describe('shellTask', () => {
     mockSpawn.mockReset();
   });
   it('should handle non zero exit code', async () => {
+    mockSpawn.mockReset();
     mockSpawn.mockImplementationOnce(() => ({
       on: (_event: string, cb: (...args: any[]) => void) => {
         cb(1);
@@ -183,6 +184,7 @@ describe('shellTask', () => {
     mockSpawn.mockReset();
   });
   it('should skip when condition does not meet', async () => {
+    mockSpawn.mockReset();
     const task: ShellTaskType = {
       task: 'shell',
       actions: [
@@ -205,6 +207,7 @@ describe('shellTask', () => {
     mockSpawn.mockReset();
   });
   it('should skip when execution not allowed', async () => {
+    mockSpawn.mockReset();
     mockPrompter.confirm.mockClear();
     mockPrompter.confirm.mockReturnValueOnce(false);
 

src/__tests__/unit/tasks/shellTask.spec.ts

@@ -12,7 +12,6 @@ describe('setState', () => {
     } as TaskState);
     setState('test', {
       state: 'done',
-      error: false,
     });
     expect(variables.get<TaskState>('test')).toEqual({
       state: 'skipped',

src/__tests__/unit/utils/setState.spec.ts

@@ -263,14 +263,12 @@ export async function integrate(packageName?: string): Promise<void> {
           if (task.when && !checkCondition(task.when)) {
             setState(task.name, {
               state: 'skipped',
-              error: false,
             });
             continue;
           }
 
           setState(task.name, {
             state: 'progress',
-            error: false,
           });
 
           const isNonSystemTask = !taskManager.isSystemTask(task.task);
@@ -294,7 +292,6 @@ export async function integrate(packageName?: string): Promise<void> {
 
             setState(task.name, {
               state: 'done',
-              error: false,
             });
             await logInfoNote(task.postInfo);
           } catch (e) {
@@ -305,7 +302,6 @@ export async function integrate(packageName?: string): Promise<void> {
             setState(task.name, {
               state: 'error',
               reason: errMessage,
-              error: true,
             });
           }
         }

src/integrate.ts

@@ -40,14 +40,12 @@ export async function androidManifestTask(args: {
       setState(action.name, {
         state: 'skipped',
         reason: 'when',
-        error: false,
       });
       continue;
     }
 
     setState(action.name, {
       state: 'progress',
-      error: false,
     });
     try {
       const additionalModification = (args: {
@@ -67,13 +65,11 @@ export async function androidManifestTask(args: {
 
       setState(action.name, {
         state: 'done',
-        error: false,
       });
     } catch (e) {
       setState(action.name, {
         state: 'error',
         reason: getErrMessage(e),
-        error: true,
       });
       throw e;
     }

src/tasks/androidManifestTask.ts

@@ -31,14 +31,12 @@ export async function appDelegateTask(args: {
       setState(action.name, {
         state: 'skipped',
         reason: 'when',
-        error: false,
       });
       continue;
     }
 
     setState(action.name, {
       state: 'progress',
-      error: false,
     });
     try {
       content = await applyContentModification({
@@ -52,13 +50,11 @@ export async function appDelegateTask(args: {
 
       setState(action.name, {
         state: 'done',
-        error: false,
       });
     } catch (e) {
       setState(action.name, {
         state: 'error',
         reason: getErrMessage(e),
-        error: true,
       });
       throw e;
     }

src/tasks/appDelegateTask.ts

@@ -33,14 +33,12 @@ export async function babelConfigTask(args: {
       setState(action.name, {
         state: 'skipped',
         reason: 'when',
-        error: false,
       });
       continue;
     }
 
     setState(action.name, {
       state: 'progress',
-      error: false,
     });
     try {
       if ('mode' in action && action.mode === 'text') {
@@ -58,13 +56,11 @@ export async function babelConfigTask(args: {
       }
       setState(action.name, {
         state: 'done',
-        error: false,
       });
     } catch (e) {
       setState(action.name, {
         state: 'error',
         reason: getErrMessage(e),
-        error: true,
       });
       throw e;
     }
@@ -123,7 +119,6 @@ export function shouldApplyInsertion(
       setState(action.name, {
         state: 'skipped',
         reason: 'insert.ifNotPresent',
-        error: false,
       });
       return false;
     }
@@ -134,7 +129,6 @@ export function shouldApplyInsertion(
     setState(action.name, {
       state: 'skipped',
       reason: 'insert.exists',
-      error: false,
     });
     return false;
   }

src/tasks/babelConfigTask.ts

@@ -30,14 +30,12 @@ export async function buildGradleTask(args: {
       setState(action.name, {
         state: 'skipped',
         reason: 'when',
-        error: false,
       });
       continue;
     }
 
     setState(action.name, {
       state: 'progress',
-      error: false,
     });
     try {
       content = await applyContentModification({
@@ -50,13 +48,11 @@ export async function buildGradleTask(args: {
       });
       setState(action.name, {
         state: 'done',
-        error: false,
       });
     } catch (e) {
       setState(action.name, {
         state: 'error',
         reason: getErrMessage(e),
-        error: true,
       });
       throw e;
     }

src/tasks/buildGradleTask.ts

@@ -24,26 +24,22 @@ export async function fsTask(args: {
       setState(action.name, {
         state: 'skipped',
         reason: 'when',
-        error: false,
       });
       continue;
     }
 
     setState(action.name, {
       state: 'progress',
-      error: false,
     });
     try {
       await applyFsModification(action, packageName);
       setState(action.name, {
         state: 'done',
-        error: false,
       });
     } catch (e) {
       setState(action.name, {
         state: 'error',
         reason: getErrMessage(e),
-        error: true,
       });
       throw e;
     }