feat: extract iOS and Android specific linking files out of the core (react-native-community#290)

Summary:
---------

Historically, Android and iOS platform were hardcoded inside CLI and provided by default. Then, other packages could export additional platforms on top of it.

React Native as a platform was hardcoded in Metro configuration (default platforms, default extensions) and inside link. That means all new features were always developed with these platforms in mind, leaving others behind. We often used private APIs, which made things more complicated for 3rd party platform developers.

From this PR on, there's no longer concept of an out-of-tree platform inside of the CLI. In a follow up PR to React Native, I am going to configure iOS and Android platforms inside React Native, just like React Native Windows exposes Windows platform.

This will open room for improvements and should make it even easier for the CLI to welcome other platforms.

Author: grabbou

.circleci/config.yml

@@ -16,7 +16,7 @@ jobs:
           keys:
             - v2-dependencies-{{ checksum "package.json" }}
             - v2-dependencies-
-      - run: yarn install
+      - run: yarn --frozen-lockfile
       - save_cache:
           key: v2-dependencies-{{ checksum "package.json" }}
           paths:
@@ -25,32 +25,48 @@ jobs:
           root: .
           paths:
             - .
-  lint-and-flow:
+  lint:
     <<: *defaults
     steps:
       - attach_workspace:
           at: ~/react-native-cli
-      - run: |
-          yarn lint
-          yarn flow-check
-  tests:
+      - run: yarn lint
+  typecheck:
     <<: *defaults
     steps:
       - attach_workspace:
           at: ~/react-native-cli
-      - run: yarn test:ci
+      - run: yarn flow-check
+  unit-tests:
+    <<: *defaults
+    steps:
+      - attach_workspace:
+          at: ~/react-native-cli
+      - run: yarn test:ci:unit
       - store_artifacts:
           path: coverage
           destination: coverage
+  e2e-tests:
+    <<: *defaults
+    steps:
+      - attach_workspace:
+          at: ~/react-native-cli
+      - run: yarn test:ci:e2e
 
 workflows:
   version: 2
   build-and-test:
     jobs:
       - install-dependencies
-      - lint-and-flow:
+      - lint:
+          requires:
+            - install-dependencies
+      - typecheck:
+          requires:
+            - install-dependencies
+      - unit-tests:
           requires:
             - install-dependencies
-      - tests:
+      - e2e-tests:
           requires:
             - install-dependencies

.eslintrc.js

@@ -13,7 +13,7 @@ module.exports = {
   },
   overrides: [
     {
-      files: ['**/__mocks__/**', '**/__fixtures__/**', 'testSetup.js'],
+      files: ['**/__mocks__/**', '**/__fixtures__/**', '**/__e2e__/**', 'jest/**'],
       env: {
         jest: true,
       },

e2e/__tests__/__snapshots__/init.test.js.snap renamed to __e2e__/__snapshots__/init.test.js.snap

@@ -1,7 +1,7 @@
 // @flow
 import fs from 'fs';
 import path from 'path';
-import {run, getTempDirectory, cleanup, writeFiles} from '../helpers';
+import {run, getTempDirectory, cleanup, writeFiles} from '../jest/helpers';
 
 const DIR = getTempDirectory('command-init');
 
@@ -14,11 +14,11 @@ afterEach(() => {
 });
 
 test('init --template fails without package name', () => {
-  const {stderr} = run(DIR, [
-    'init',
-    '--template',
-    'react-native-new-template',
-  ]);
+  const {stderr} = run(
+    DIR,
+    ['init', '--template', 'react-native-new-template'],
+    {expectedFailure: true},
+  );
   expect(stderr).toContain('missing required argument');
 });
 

e2e/__tests__/init.test.js renamed to __e2e__/init.test.js

@@ -1,6 +1,6 @@
 // @flow
 import path from 'path';
-import {run, getTempDirectory, cleanup, writeFiles} from '../helpers';
+import {run, getTempDirectory, cleanup, writeFiles} from '../jest/helpers';
 
 const DIR = getTempDirectory('command-install-test');
 const pkg = 'react-native-config';

e2e/__tests__/install.test.js renamed to __e2e__/install.test.js

@@ -2,7 +2,7 @@
 import fs from 'fs';
 import path from 'path';
 import execa from 'execa';
-import {getTempDirectory, cleanup, writeFiles} from '../helpers';
+import {getTempDirectory, cleanup, writeFiles} from '../jest/helpers';
 
 const DIR = getTempDirectory('command-legacy-init');
 

e2e/__tests__/legacyInit.test.js renamed to __e2e__/legacyInit.test.js

@@ -1,5 +1,5 @@
 // @flow
-import {run, getTempDirectory, cleanup, writeFiles} from '../helpers';
+import {run, getTempDirectory, cleanup, writeFiles} from '../jest/helpers';
 
 const DIR = getTempDirectory('command-uninstall-test');
 const pkg = 'react-native-config';

e2e/__tests__/uninstall.test.js renamed to __e2e__/uninstall.test.js

@@ -1,4 +1,18 @@
+const common = {testEnvironment: 'node'};
+
 module.exports = {
-  testEnvironment: 'node',
-  projects: ['<rootDir>/packages/*', '<rootDir>/e2e'],
+  projects: [
+    {
+      ...common,
+      displayName: 'e2e',
+      setupFiles: ['<rootDir>/jest/setupE2eTests.js'],
+      testMatch: ['<rootDir>/**/__e2e__/*{.,-}test.js'],
+    },
+    {
+      ...common,
+      displayName: 'unit',
+      setupFiles: ['<rootDir>/jest/setupUnitTests.js'],
+      testMatch: ['<rootDir>/**/__tests__/*{.,-}test.js'],
+    },
+  ],
 };

packages/cli/src/__mocks__/fs.js renamed to __mocks__/fs.js

@@ -0,0 +1,19 @@
+/**
+ * @flow
+ */
+
+jest.mock('@react-native-community/cli-tools', () => ({
+  ...jest.requireActual('@react-native-community/cli-tools'),
+  logger: {
+    success: jest.fn(),
+    info: jest.fn(),
+    warn: jest.fn(),
+    error: jest.fn(),
+    debug: jest.fn(),
+    log: jest.fn(),
+    setVerbose: jest.fn(),
+    isVerbose: jest.fn(),
+  },
+}));
+
+jest.setTimeout(20000);

packages/cli/src/__mocks__/path.js renamed to __mocks__/path.js

@@ -1,6 +1,6 @@
 {
   "lerna": "3.10.6",
-  "version": "independent",
+  "version": "2.0.0-alpha.3",
   "npmClient": "yarn",
   "useWorkspaces": true
 }

e2e/jest.config.js

@@ -8,7 +8,8 @@
     "build-clean": "rm -rf ./packages/*/build",
     "watch": "node ./scripts/watch.js",
     "test": "jest",
-    "test:ci": "jest -i",
+    "test:ci:unit": "jest packages --ci --coverage",
+    "test:ci:e2e": "jest e2e --ci -i",
     "lint": "eslint . --cache --report-unused-disable-directives",
     "flow-check": "flow check",
     "postinstall": "yarn build-clean && yarn build",

jest.config.js

@@ -19,6 +19,9 @@
     "testEnvironment": "node"
   },
   "dependencies": {
+    "@react-native-community/cli-platform-ios": "2.0.0-alpha.3",
+    "@react-native-community/cli-platform-android": "2.0.0-alpha.3",
+    "@react-native-community/cli-tools": "2.0.0-alpha.3",
     "chalk": "^1.1.1",
     "commander": "^2.19.0",
     "compression": "^1.7.1",

e2e/helpers.js renamed to jest/helpers.js

@@ -17,7 +17,7 @@ import type {CommandT, ContextT} from './tools/types.flow';
 import {getCommands} from './commands';
 import init from './commands/init/initCompat';
 import assertRequiredOptions from './tools/assertRequiredOptions';
-import logger from './tools/logger';
+import {logger} from '@react-native-community/cli-tools';
 import {setProjectDir} from './tools/packageManager';
 import pkgJson from '../package.json';
 import loadConfig from './tools/config';

e2e/testSetup.js renamed to jest/setupE2eTests.js

@@ -16,7 +16,7 @@ import type {CommandLineArgs} from './bundleCommandLineArgs';
 import type {ContextT} from '../../tools/types.flow';
 import saveAssets from './saveAssets';
 import loadMetroConfig from '../../tools/loadMetroConfig';
-import logger from '../../tools/logger';
+import {logger} from '@react-native-community/cli-tools';
 
 async function buildBundle(
   args: CommandLineArgs,

jest/setupUnitTests.js

@@ -14,7 +14,7 @@ import fs from 'fs';
 import filterPlatformAssetScales from './filterPlatformAssetScales';
 import getAssetDestPathAndroid from './getAssetDestPathAndroid';
 import getAssetDestPathIOS from './getAssetDestPathIOS';
-import logger from '../../tools/logger';
+import {logger} from '@react-native-community/cli-tools';
 
 function saveAssets(assets, platform, assetsDest) {
   if (!assetsDest) {

lerna.json

@@ -1,12 +1,14 @@
 // @flow
 import info from '../info';
-import logger from '../../../tools/logger';
+import {logger} from '@react-native-community/cli-tools';
 import loadConfig from '../../../tools/config';
 
-jest.mock('../../../tools/logger', () => ({
-  info: jest.fn(),
-  error: jest.fn(),
-  log: jest.fn(),
+jest.mock('@react-native-community/cli-tools', () => ({
+  logger: {
+    info: jest.fn(),
+    error: jest.fn(),
+    log: jest.fn(),
+  },
 }));
 
 jest.mock('../../../tools/config');

package.json

@@ -8,7 +8,7 @@
  */
 
 import envinfo from 'envinfo';
-import logger from '../../tools/logger';
+import {logger} from '@react-native-community/cli-tools';
 import type {ContextT} from '../../tools/types.flow';
 
 const info = async function getInfo(

packages/cli/jest.config.js

@@ -2,7 +2,7 @@
 import fs from 'fs-extra';
 import path from 'path';
 import walk from '../../tools/walk';
-import logger from '../../tools/logger';
+import {logger} from '@react-native-community/cli-tools';
 
 function replaceNameInUTF8File(
   filePath: string,

packages/cli/package.json

@@ -6,7 +6,7 @@ import type {ContextT} from '../../tools/types.flow';
 import {validateProjectName} from './validate';
 import DirectoryAlreadyExistsError from './errors/DirectoryAlreadyExistsError';
 import printRunInstructions from './printRunInstructions';
-import logger from '../../tools/logger';
+import {logger} from '@react-native-community/cli-tools';
 import {
   installTemplatePackage,
   getTemplateConfig,

packages/cli/src/cliEntry.js

@@ -14,7 +14,7 @@ import process from 'process';
 import printRunInstructions from './printRunInstructions';
 import {createProjectFromTemplate} from '../../tools/generator/templates';
 import * as PackageManager from '../../tools/packageManager';
-import logger from '../../tools/logger';
+import {logger} from '@react-native-community/cli-tools';
 
 /**
  * Creates the template for a React Native project given the provided

packages/cli/src/commands/bundle/buildBundle.js

@@ -10,7 +10,7 @@
 
 import path from 'path';
 import chalk from 'chalk';
-import logger from '../../tools/logger';
+import {logger} from '@react-native-community/cli-tools';
 
 function printRunInstructions(projectDir: string, projectName: string) {
   const absoluteProjectDir = path.resolve(projectDir);

packages/cli/src/commands/bundle/saveAssets.js

@@ -3,7 +3,7 @@
 import execa from 'execa';
 import path from 'path';
 import * as PackageManager from '../../tools/packageManager';
-import logger from '../../tools/logger';
+import {logger} from '@react-native-community/cli-tools';
 import copyFiles from '../../tools/copyFiles';
 
 export type TemplateConfig = {

packages/cli/src/commands/info/__tests__/info.test.js

@@ -8,7 +8,7 @@
  */
 
 import type {ContextT} from '../../tools/types.flow';
-import logger from '../../tools/logger';
+import {logger} from '@react-native-community/cli-tools';
 import * as PackageManager from '../../tools/packageManager';
 import link from '../link/link';
 import loadConfig from '../../tools/config';

packages/cli/src/commands/info/info.js

@@ -8,7 +8,7 @@
  */
 
 import type {ContextT} from '../../tools/types.flow';
-import logger from '../../tools/logger';
+import {logger} from '@react-native-community/cli-tools';
 import * as PackageManager from '../../tools/packageManager';
 import link from '../link/unlink';
 

packages/cli/src/commands/init/editTemplate.js

@@ -12,7 +12,7 @@ import path from 'path';
 import copyAndReplace from '../../tools/copyAndReplace';
 import isValidPackageName from '../../tools/isValidPackageName';
 import walk from '../../tools/walk';
-import logger from '../../tools/logger';
+import {logger} from '@react-native-community/cli-tools';
 
 /**
  * Creates a new native library with the given name