Skip to content

Commit e5ab37d

Browse files
filipesilvabenlesh
filipesilva
authored and
benlesh
committed
Test for side effects, and remove existing ones (ReactiveX#4769)
* test: add test for side-effects * refactor: remove toplevel property access
1 parent bd5ec2d commit e5ab37d

32 files changed

+484
-102
lines changed

‎.circleci/config.yml

+1
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ jobs:
5050
steps:
5151
- attach_workspace: *attach_options
5252
- run: npm test
53+
- run: npm run test:side-effects
5354

5455
dtslint:
5556
<<: *defaults

‎.eslintignore

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
integration/side-effects/snapshots/

‎.gitignore

+4
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,7 @@ spec-build/
2323
# Misc
2424
npm-debug.log
2525
.DS_STORE
26+
27+
# The check-side-effects package generates and deletes this file.
28+
# If the process is killed, it will be left behind.
29+
check-side-effects.tmp-input.js

‎integration/side-effects/README.md

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
This test checks if the side effects for loading RxJs packages have changed using <https://github.com/filipesilva/check-side-effects>.
2+
3+
Running `npm test:side-effects` will check all ES modules listed in `side-effects.json`.
4+
5+
Running `npm test:side-effects:update` will update any changed side effects.
6+
7+
To add a new ES module to this test, add a new entry in `side-effects.json`.
8+
9+
Usually the ESM and FESM should have the same output, but retained objects that were renamed during the flattening step will leave behind a different name.

‎integration/side-effects/side-effects.json

+52
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
{
2+
"tests": [
3+
{
4+
"esModules": "../../dist/esm5/index.js",
5+
"expectedOutput": "./snapshots/esm5/index.js"
6+
},
7+
{
8+
"esModules": "../../dist/esm2015/index.js",
9+
"expectedOutput": "./snapshots/esm2015/index.js"
10+
},
11+
{
12+
"esModules": "../../dist/esm5/ajax/index.js",
13+
"expectedOutput": "./snapshots/esm5/ajax.js"
14+
},
15+
{
16+
"esModules": "../../dist/esm2015/ajax/index.js",
17+
"expectedOutput": "./snapshots/esm2015/ajax.js"
18+
},
19+
{
20+
"esModules": "../../dist/esm5/fetch/index.js",
21+
"expectedOutput": "./snapshots/esm5/fetch.js"
22+
},
23+
{
24+
"esModules": "../../dist/esm2015/fetch/index.js",
25+
"expectedOutput": "./snapshots/esm2015/fetch.js"
26+
},
27+
{
28+
"esModules": "../../dist/esm5/operators/index.js",
29+
"expectedOutput": "./snapshots/esm5/operators.js"
30+
},
31+
{
32+
"esModules": "../../dist/esm2015/operators/index.js",
33+
"expectedOutput": "./snapshots/esm2015/operators.js"
34+
},
35+
{
36+
"esModules": "../../dist/esm5/testing/index.js",
37+
"expectedOutput": "./snapshots/esm5/testing.js"
38+
},
39+
{
40+
"esModules": "../../dist/esm2015/testing/index.js",
41+
"expectedOutput": "./snapshots/esm2015/testing.js"
42+
},
43+
{
44+
"esModules": "../../dist/esm5/webSocket/index.js",
45+
"expectedOutput": "./snapshots/esm5/websocket.js"
46+
},
47+
{
48+
"esModules": "../../dist/esm2015/webSocket/index.js",
49+
"expectedOutput": "./snapshots/esm2015/websocket.js"
50+
}
51+
]
52+
}

‎integration/side-effects/snapshots/esm2015/ajax.js

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+

‎integration/side-effects/snapshots/esm2015/fetch.js

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+

‎integration/side-effects/snapshots/esm2015/index.js

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
var NotificationKind;
2+
3+
(function(NotificationKind) {
4+
NotificationKind["NEXT"] = "N";
5+
NotificationKind["ERROR"] = "E";
6+
NotificationKind["COMPLETE"] = "C";
7+
})(NotificationKind || (NotificationKind = {}));

‎integration/side-effects/snapshots/esm2015/operators.js

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
var NotificationKind;
2+
3+
(function(NotificationKind) {
4+
NotificationKind["NEXT"] = "N";
5+
NotificationKind["ERROR"] = "E";
6+
NotificationKind["COMPLETE"] = "C";
7+
})(NotificationKind || (NotificationKind = {}));

‎integration/side-effects/snapshots/esm2015/testing.js

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
var NotificationKind;
2+
3+
(function(NotificationKind) {
4+
NotificationKind["NEXT"] = "N";
5+
NotificationKind["ERROR"] = "E";
6+
NotificationKind["COMPLETE"] = "C";
7+
})(NotificationKind || (NotificationKind = {}));

‎integration/side-effects/snapshots/esm2015/websocket.js

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
var NotificationKind;
2+
3+
(function(NotificationKind) {
4+
NotificationKind["NEXT"] = "N";
5+
NotificationKind["ERROR"] = "E";
6+
NotificationKind["COMPLETE"] = "C";
7+
})(NotificationKind || (NotificationKind = {}));

‎integration/side-effects/snapshots/esm5/ajax.js

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import "tslib";

‎integration/side-effects/snapshots/esm5/fetch.js

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import "tslib";

‎integration/side-effects/snapshots/esm5/index.js

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import "tslib";

‎integration/side-effects/snapshots/esm5/operators.js

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import "tslib";

‎integration/side-effects/snapshots/esm5/testing.js

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import "tslib";

‎integration/side-effects/snapshots/esm5/websocket.js

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import "tslib";

0 commit comments

Comments
 (0)