Skip to content

Commit e228dc7

Browse files
vonovakthymikee
andcommitted
fix: support linking of BaseReactPackage subclasses (#2563)
* fix: support linking of BaseReactPackage subclasses * Update packages/cli-config-android/src/config/__tests__/findPackageClassName.test.ts Co-authored-by: Michał Pierzchała <[email protected]> --------- Co-authored-by: Michał Pierzchała <[email protected]>
1 parent d45c4e6 commit e228dc7

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

packages/cli-platform-android/src/config/__fixtures__/android.ts

+11
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,10 @@ export const findPackagesClassNameKotlinValid = [
203203
`
204204
class SomeExampleKotlinPackage : TurboReactPackage {
205205
206+
}`,
207+
`
208+
class SomeExampleKotlinPackage : BaseReactPackage {
209+
206210
}`,
207211
];
208212

@@ -265,6 +269,13 @@ export const findPackagesClassNameJavaValid = [
265269
extends
266270
TurboReactPackage {
267271
272+
}
273+
`,
274+
`
275+
class SomeExampleKotlinPackage
276+
extends
277+
BaseReactPackage {
278+
268279
}
269280
`,
270281
`

packages/cli-platform-android/src/config/findPackageClassName.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export function matchClassName(file: string) {
7676
return nativeModuleMatch;
7777
} else {
7878
return file.match(
79-
/class\s+(\w+[^(\s]*)[\s\w():]*(\s+extends\s+|:)[\s\w():,]*[^{]*TurboReactPackage/,
79+
/class\s+(\w+[^(\s]*)[\s\w():]*(\s+extends\s+|:)[\s\w():,]*[^{]*(Turbo|Base)ReactPackage/,
8080
);
8181
}
8282
}

0 commit comments

Comments
 (0)