Skip to content

Commit 51a9215

Browse files
authored
chore: bump @rc-component deps (#571)
* chore: bump deps * test: fix test logic * test: fix deps * chore: use npm test * chore: rm now
1 parent 4535161 commit 51a9215

16 files changed

+50
-83
lines changed

.github/workflows/main.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ name: ✅ test
22
on: [push, pull_request]
33
jobs:
44
test:
5-
uses: react-component/rc-test/.github/workflows/test.yml@main
5+
uses: react-component/rc-test/.github/workflows/test-npm.yml@main
66
secrets: inherit

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ $ npm install rc-cascader --save
5454

5555
```js
5656
import React from 'react';
57-
import Cascader from 'rc-cascader';
57+
import Cascader from '@rc-component/cascader';
5858

5959
const options = [{
6060
'label': '福建',
@@ -169,7 +169,7 @@ React.render(
169169
<td>visibility of popup overlay</td>
170170
</tr>
171171
<tr>
172-
<td>onDropdownVisibleChange</td>
172+
<td>onPopupVisibleChange</td>
173173
<td>Function(visible)</td>
174174
<td></td>
175175
<td>callback when popup overlay's visibility changed</td>
@@ -187,7 +187,7 @@ React.render(
187187
<td>prefix className of popup overlay</td>
188188
</tr>
189189
<tr>
190-
<td>dropdownClassName</td>
190+
<td>popupClassName</td>
191191
<td>String</td>
192192
<td></td>
193193
<td>additional className of popup overlay</td>

assets/select.less

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
@import '~rc-select/assets/index';
1+
@import '~@rc-component/select/assets/index';
22

33
@select-prefix: ~'rc-cascader';

examples/dropdown-render.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ const Demo = () => {
7070
<Cascader
7171
options={addressOptions}
7272
onChange={onChange}
73-
dropdownRender={menus => (
73+
popupRender={menus => (
7474
<div>
7575
{menus}
7676
<hr />

now.json

-11
This file was deleted.

package.json

+11-11
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
"name": "rc-cascader",
3-
"version": "3.33.0",
2+
"name": "@rc-component/cascader",
3+
"version": "1.0.0",
44
"description": "cascade select ui component for react",
55
"keywords": [
66
"react",
@@ -36,21 +36,21 @@
3636
"deploy": "UMI_ENV=gh npm run build && gh-pages -d dist",
3737
"lint": "eslint src/ examples/ --ext .tsx,.ts,.jsx,.jsx",
3838
"now-build": "npm run build",
39-
"prepublishOnly": "npm run compile && np --no-cleanup --yolo --no-publish",
39+
"prepublishOnly": "npm run compile && rc-np",
4040
"lint:tsc": "tsc -p tsconfig.json --noEmit",
4141
"start": "dumi dev",
4242
"test": "rc-test"
4343
},
4444
"dependencies": {
45-
"@babel/runtime": "^7.25.7",
45+
"@rc-component/select": "~1.0.0",
46+
"@rc-component/util": "^1.2.1",
4647
"classnames": "^2.3.1",
47-
"rc-select": "~14.16.2",
48-
"rc-tree": "~5.13.0",
49-
"rc-util": "^5.43.0"
48+
"rc-tree": "~5.13.1"
5049
},
5150
"devDependencies": {
52-
"@rc-component/father-plugin": "^1.0.0",
53-
"@rc-component/trigger": "^1.5.0",
51+
"@rc-component/father-plugin": "^2.0.2",
52+
"@rc-component/np": "^1.0.3",
53+
"@rc-component/trigger": "^3.0.0",
5454
"@testing-library/react": "^12.1.5",
5555
"@types/classnames": "^2.2.6",
5656
"@types/enzyme": "^3.1.15",
@@ -61,6 +61,7 @@
6161
"@umijs/fabric": "^4.0.0",
6262
"array-tree-filter": "^3.0.2",
6363
"cheerio": "1.0.0-rc.12",
64+
"core-js": "^3.40.0",
6465
"cross-env": "^7.0.0",
6566
"dumi": "^2.1.10",
6667
"enzyme": "^3.3.0",
@@ -73,10 +74,9 @@
7374
"gh-pages": "^6.1.1",
7475
"glob": "^7.1.6",
7576
"less": "^4.2.0",
76-
"np": "^10.0.2",
7777
"prettier": "^3.1.0",
7878
"rc-field-form": "^1.44.0",
79-
"rc-test": "^7.0.14",
79+
"rc-test": "^7.1.2",
8080
"react": "^16.0.0",
8181
"react-dom": "^16.0.0",
8282
"typescript": "^5.3.2"

src/Cascader.tsx

+16-24
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import type { BuildInPlacements } from '@rc-component/trigger/lib/interface';
2-
import type { BaseSelectProps, BaseSelectPropsWithoutPrivate, BaseSelectRef } from 'rc-select';
3-
import { BaseSelect } from 'rc-select';
4-
import type { DisplayValueType, Placement } from 'rc-select/lib/BaseSelect';
5-
import useId from 'rc-select/lib/hooks/useId';
6-
import useEvent from 'rc-util/lib/hooks/useEvent';
7-
import useMergedState from 'rc-util/lib/hooks/useMergedState';
2+
import type { BaseSelectProps, BaseSelectPropsWithoutPrivate, BaseSelectRef } from '@rc-component/select';
3+
import { BaseSelect } from '@rc-component/select';
4+
import type { DisplayValueType, Placement } from '@rc-component/select/lib/BaseSelect';
5+
import useId from '@rc-component/select/lib/hooks/useId';
6+
import useEvent from '@rc-component/util/lib/hooks/useEvent';
7+
import useMergedState from '@rc-component/util/lib/hooks/useMergedState';
88
import * as React from 'react';
99
import CascaderContext from './context';
1010
import useDisplayValues from './hooks/useDisplayValues';
@@ -102,19 +102,15 @@ interface BaseCascaderProps<
102102
/** @deprecated Use `open` instead */
103103
popupVisible?: boolean;
104104

105-
/** @deprecated Use `dropdownClassName` instead */
106105
popupClassName?: string;
107-
dropdownClassName?: string;
108106
dropdownMenuColumnStyle?: React.CSSProperties;
109107

110108
/** @deprecated Use `placement` instead */
111109
popupPlacement?: Placement;
112110
placement?: Placement;
113111
builtinPlacements?: BuildInPlacements;
114112

115-
/** @deprecated Use `onDropdownVisibleChange` instead */
116113
onPopupVisibleChange?: (open: boolean) => void;
117-
onDropdownVisibleChange?: (open: boolean) => void;
118114

119115
// Icon
120116
expandIcon?: React.ReactNode;
@@ -213,14 +209,12 @@ const Cascader = React.forwardRef<CascaderRef, InternalCascaderProps>((props, re
213209
open,
214210

215211
popupClassName,
216-
dropdownClassName,
217212
dropdownMenuColumnStyle,
218-
dropdownStyle: customDropdownStyle,
213+
popupStyle: customPopupStyle,
219214

220215
popupPlacement,
221216
placement,
222217

223-
onDropdownVisibleChange,
224218
onPopupVisibleChange,
225219

226220
// Icon
@@ -229,7 +223,7 @@ const Cascader = React.forwardRef<CascaderRef, InternalCascaderProps>((props, re
229223

230224
// Children
231225
children,
232-
dropdownMatchSelectWidth = false,
226+
popupMatchSelectWidth = false,
233227
showCheckedStrategy = SHOW_PARENT,
234228
optionRender,
235229
...restProps
@@ -374,12 +368,10 @@ const Cascader = React.forwardRef<CascaderRef, InternalCascaderProps>((props, re
374368
// ============================ Open ============================
375369
const mergedOpen = open !== undefined ? open : popupVisible;
376370

377-
const mergedDropdownClassName = dropdownClassName || popupClassName;
378371

379372
const mergedPlacement = placement || popupPlacement;
380373

381-
const onInternalDropdownVisibleChange = (nextVisible: boolean) => {
382-
onDropdownVisibleChange?.(nextVisible);
374+
const onInternalPopupVisibleChange = (nextVisible: boolean) => {
383375
onPopupVisibleChange?.(nextVisible);
384376
};
385377

@@ -432,7 +424,7 @@ const Cascader = React.forwardRef<CascaderRef, InternalCascaderProps>((props, re
432424
// ==============================================================
433425
const emptyOptions = !(mergedSearchValue ? searchOptions : mergedOptions).length;
434426

435-
const dropdownStyle: React.CSSProperties =
427+
const popupStyle: React.CSSProperties =
436428
// Search to match width
437429
(mergedSearchValue && searchConfig.matchInputWidth) ||
438430
// Empty keep the width
@@ -451,10 +443,10 @@ const Cascader = React.forwardRef<CascaderRef, InternalCascaderProps>((props, re
451443
id={mergedId}
452444
prefixCls={prefixCls}
453445
autoClearSearchValue={autoClearSearchValue}
454-
dropdownMatchSelectWidth={dropdownMatchSelectWidth}
455-
dropdownStyle={{
456-
...dropdownStyle,
457-
...customDropdownStyle,
446+
popupMatchSelectWidth={popupMatchSelectWidth}
447+
popupStyle={{
448+
...popupStyle,
449+
...customPopupStyle,
458450
}}
459451
// Value
460452
displayValues={displayValues}
@@ -469,9 +461,9 @@ const Cascader = React.forwardRef<CascaderRef, InternalCascaderProps>((props, re
469461
emptyOptions={emptyOptions}
470462
// Open
471463
open={mergedOpen}
472-
dropdownClassName={mergedDropdownClassName}
464+
popupClassName={popupClassName}
473465
placement={mergedPlacement}
474-
onDropdownVisibleChange={onInternalDropdownVisibleChange}
466+
onPopupVisibleChange={onInternalPopupVisibleChange}
475467
// Children
476468
getRawInputElement={() => children as React.ReactElement}
477469
/>

src/OptionList/List.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/* eslint-disable default-case */
22
import classNames from 'classnames';
3-
import type { useBaseProps } from 'rc-select';
4-
import type { RefOptionListProps } from 'rc-select/lib/OptionList';
3+
import type { useBaseProps } from '@rc-component/select';
4+
import type { RefOptionListProps } from '@rc-component/select/lib/OptionList';
55
import * as React from 'react';
66
import type { DefaultOptionType, SingleValueType } from '../Cascader';
77
import CascaderContext from '../context';

src/OptionList/index.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { useBaseProps } from 'rc-select';
2-
import type { RefOptionListProps } from 'rc-select/lib/OptionList';
1+
import { useBaseProps } from '@rc-component/select';
2+
import type { RefOptionListProps } from '@rc-component/select/lib/OptionList';
33
import * as React from 'react';
44
import RawOptionList from './List';
55

src/OptionList/useKeyboard.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import type { RefOptionListProps } from 'rc-select/lib/OptionList';
2-
import KeyCode from 'rc-util/lib/KeyCode';
1+
import type { RefOptionListProps } from '@rc-component/select/lib/OptionList';
2+
import KeyCode from '@rc-component/util/lib/KeyCode';
33
import * as React from 'react';
44
import type { DefaultOptionType, InternalFieldNames, SingleValueType } from '../Cascader';
55
import { SEARCH_MARK } from '../hooks/useSearchOptions';

src/Panel.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import classNames from 'classnames';
2-
import { useEvent, useMergedState } from 'rc-util';
2+
import { useEvent, useMergedState } from '@rc-component/util';
33
import * as React from 'react';
44
import type {
55
CascaderProps,

src/hooks/useSearchConfig.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import warning from 'rc-util/lib/warning';
1+
import warning from '@rc-component/util/lib/warning';
22
import * as React from 'react';
33
import type { CascaderProps, ShowSearchType } from '../Cascader';
44

src/utils/warningPropsUtil.ts

+2-10
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,10 @@
1-
import warning from 'rc-util/lib/warning';
1+
import warning from '@rc-component/util/lib/warning';
22
import type { DefaultOptionType, FieldNames, InternalCascaderProps } from '../Cascader';
33

44
function warningProps(props: InternalCascaderProps) {
5-
const { onPopupVisibleChange, popupVisible, popupClassName, popupPlacement } = props;
5+
const { popupVisible, popupPlacement } = props;
66

7-
warning(
8-
!onPopupVisibleChange,
9-
'`onPopupVisibleChange` is deprecated. Please use `onDropdownVisibleChange` instead.',
10-
);
117
warning(popupVisible === undefined, '`popupVisible` is deprecated. Please use `open` instead.');
12-
warning(
13-
popupClassName === undefined,
14-
'`popupClassName` is deprecated. Please use `dropdownClassName` instead.',
15-
);
168
warning(
179
popupPlacement === undefined,
1810
'`popupPlacement` is deprecated. Please use `placement` instead.',

tests/index.spec.tsx

+4-10
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { spyElementPrototypes } from 'rc-util/lib/test/domHook';
2-
import { resetWarned } from 'rc-util/lib/warning';
1+
import { spyElementPrototypes } from '@rc-component/util/lib/test/domHook';
2+
import { resetWarned } from '@rc-component/util/lib/warning';
33
import React, { useEffect, useState } from 'react';
44
import type { CascaderRef, BaseOptionType, CascaderProps } from '../src';
55
import Cascader from '../src';
@@ -527,15 +527,9 @@ describe('Cascader.Basic', () => {
527527
/>,
528528
);
529529

530-
expect(errorSpy).toHaveBeenCalledWith(
531-
'Warning: `onPopupVisibleChange` is deprecated. Please use `onDropdownVisibleChange` instead.',
532-
);
533530
expect(errorSpy).toHaveBeenCalledWith(
534531
'Warning: `popupVisible` is deprecated. Please use `open` instead.',
535532
);
536-
expect(errorSpy).toHaveBeenCalledWith(
537-
'Warning: `popupClassName` is deprecated. Please use `dropdownClassName` instead.',
538-
);
539533
expect(errorSpy).toHaveBeenCalledWith(
540534
'Warning: `popupPlacement` is deprecated. Please use `placement` instead.',
541535
);
@@ -623,7 +617,7 @@ describe('Cascader.Basic', () => {
623617
<Cascader
624618
options={addressOptions}
625619
popupVisible
626-
dropdownRender={menus => (
620+
popupRender={menus => (
627621
<div className="custom-dropdown">
628622
{menus}
629623
<hr />
@@ -1108,7 +1102,7 @@ describe('Cascader.Basic', () => {
11081102
});
11091103

11101104
it('support custom cascader', () => {
1111-
const wrapper = mount(<Cascader dropdownStyle={{ zIndex: 999 }} open />);
1105+
const wrapper = mount(<Cascader popupStyle={{ zIndex: 999 }} open />);
11121106
expect(wrapper.find('.rc-cascader-dropdown').props().style?.zIndex).toBe(999);
11131107
});
11141108

tests/keyboard.spec.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { mount } from 'enzyme';
2-
import KeyCode from 'rc-util/lib/KeyCode';
2+
import KeyCode from '@rc-component/util/lib/KeyCode';
33
import type { CascaderProps } from '../src';
44
import Cascader from '../src';
55
import { addressOptions } from './demoOptions';

tests/search.spec.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { fireEvent, render } from '@testing-library/react';
2-
import KeyCode from 'rc-util/lib/KeyCode';
3-
import { resetWarned } from 'rc-util/lib/warning';
2+
import KeyCode from '@rc-component/util/lib/KeyCode';
3+
import { resetWarned } from '@rc-component/util/lib/warning';
44
import React from 'react';
55
import Cascader from '../src';
66
import { optionsForActiveMenuItems } from './demoOptions';

0 commit comments

Comments
 (0)