Merge pull request #107 from AlexKVal/airbnb

Impose `airbnb` style

Author: AlexKVal

Diff for: .eslintrc

@@ -1,4 +1,5 @@
 {
+  "extends": ["eslint-config-airbnb"],
   "env": {
     "browser": true,
     "node": true
@@ -12,15 +13,19 @@
     "babel"
   ],
   "rules": {
+    "comma-dangle": 0,
     "comma-spacing": 1,
     "key-spacing": 0,
+    "no-eq-null": 0,
+    "no-param-reassign": 0,
     "no-underscore-dangle": 0,
     "no-unused-vars": [2, { "vars": "all", "args": "none" }],
     "no-var": 2,
     "babel/object-shorthand": 2,
     "quotes": [1, "single", "avoid-escape"],
     "react/display-name": 0,
     "react/jsx-no-undef": 2,
+    "react/jsx-quotes": 0,
     "react/jsx-uses-react": 2,
     "react/no-did-mount-set-state": 2,
     "react/no-did-update-set-state": 2,

Diff for: package.json

@@ -47,6 +47,7 @@
     "colors": "^1.1.2",
     "css-loader": "^0.15.3",
     "eslint": "^1.0.0",
+    "eslint-config-airbnb": "0.0.7",
     "eslint-plugin-babel": "^1.0.0",
     "eslint-plugin-mocha": "^0.4.0",
     "eslint-plugin-react": "^3.1.0",

Diff for: scripts/bower-prepare.js

@@ -1,5 +1,5 @@
 /* globals cat, config, cp, mkdir, rm, test */
-/* eslint curly: 0 */
+/* eslint curly: 0, no-console: 0 */
 import 'colors';
 import 'shelljs/global';
 import path from 'path';

Diff for: src/LinkMixin.js

@@ -35,7 +35,7 @@ export default {
    * Sets "onClick" to "handleRouteTo".
    */
   getLinkProps() {
-    let {
+    const {
       to,
       params,
       query,

Diff for: src/MenuItemLink.js

@@ -9,7 +9,7 @@ const MenuItemLink = React.createClass({
   ],
 
   render() {
-    let props = this.getLinkProps();
+    const props = this.getLinkProps();
     delete props.onSelect; // this is done on the copy of this.props
 
     return (

Diff for: tests/.eslintrc

@@ -11,11 +11,13 @@
     "mocha"
   ],
   "rules": {
+    "func-names": 0,
     "no-alert": 0,
     "no-script-url": 0,
     "no-unused-expressions": 0,
     "react/no-multi-comp": 0,
     "react/prop-types": 0,
+    "react/sort-comp": 0,
     "mocha/no-exclusive-tests": 2
   }
 }

Diff for: tests/ButtonLink.spec.js

@@ -5,38 +5,38 @@ import ButtonLink from '../src/ButtonLink';
 import Router, { Route, RouteHandler } from 'react-router';
 import { Foo, Bar } from './TestHandlers';
 import TestLocation from 'react-router/lib/locations/TestLocation';
-let { click } = React.addons.TestUtils.Simulate;
+const { click } = React.addons.TestUtils.Simulate;
 
-describe('A ButtonLink', function () {
-  describe('with params and a query', function () {
-    it('knows how to make its href', function () {
-      let ButtonLinkHandler = React.createClass({
+describe('A ButtonLink', function() {
+  describe('with params and a query', function() {
+    it('knows how to make its href', function() {
+      const ButtonLinkHandler = React.createClass({
         render() {
           return <ButtonLink to="foo" params={{bar: 'baz'}} query={{qux: 'quux'}}>ButtonLink</ButtonLink>;
         }
       });
 
-      let routes = [
+      const routes = [
         <Route name="foo" path="foo/:bar" handler={Foo} />,
         <Route name="link" handler={ButtonLinkHandler} />
       ];
 
-      let div = document.createElement('div');
-      let testLocation = new TestLocation();
+      const div = document.createElement('div');
+      const testLocation = new TestLocation();
       testLocation.history = ['/link'];
 
-      Router.run(routes, testLocation, function (Handler) {
-        React.render(<Handler/>, div, function () {
-          let a = div.querySelector('a');
+      Router.run(routes, testLocation, function(Handler) {
+        React.render(<Handler/>, div, function() {
+          const a = div.querySelector('a');
           expect(a.getAttribute('href')).to.equal('/foo/baz?qux=quux');
         });
       });
     });
   });
 
-  describe('when its route is active', function () {
-    it('has an active class name', function (done) {
-      let ButtonLinkHandler = React.createClass({
+  describe('when its route is active', function() {
+    it('has an active class name', function(done) {
+      const ButtonLinkHandler = React.createClass({
         render() {
           return (
             <div>
@@ -52,25 +52,25 @@ describe('A ButtonLink', function () {
         }
       });
 
-      let routes = (
+      const routes = (
         <Route path="/" handler={ButtonLinkHandler}>
           <Route name="foo" handler={Foo} />
           <Route name="bar" handler={Bar} />
         </Route>
       );
 
-      let div = document.createElement('div');
-      let testLocation = new TestLocation();
+      const div = document.createElement('div');
+      const testLocation = new TestLocation();
       testLocation.history = ['/foo'];
-      let steps = [];
+      const steps = [];
 
-      function assertActive () {
-        let a = div.querySelector('a');
+      function assertActive() {
+        const a = div.querySelector('a');
         expect(a.className.split(' ').sort().join(' ')).to.equal('active btn btn-primary btn-sm dontKillMe');
       }
 
-      function assertInactive () {
-        let a = div.querySelector('a');
+      function assertInactive() {
+        const a = div.querySelector('a');
         expect(a.className.split(' ').sort().join(' ')).to.equal('btn btn-primary btn-sm dontKillMe');
       }
 
@@ -89,17 +89,17 @@ describe('A ButtonLink', function () {
         done();
       });
 
-      Router.run(routes, testLocation, function (Handler) {
+      Router.run(routes, testLocation, function(Handler) {
         React.render(<Handler/>, div, () => {
           steps.shift()();
         });
       });
     });
   });
 
-  describe('when clicked', function () {
-    it('calls a user defined click handler', function (done) {
-      let ButtonLinkHandler = React.createClass({
+  describe('when clicked', function() {
+    it('calls a user defined click handler', function(done) {
+      const ButtonLinkHandler = React.createClass({
         handleClick(event) {
           assert.ok(true);
           done();
@@ -110,27 +110,27 @@ describe('A ButtonLink', function () {
         }
       });
 
-      let routes = [
+      const routes = [
         <Route name="foo" handler={Foo} />,
         <Route name="link" handler={ButtonLinkHandler} />
       ];
-      let div = document.createElement('div');
-      let testLocation = new TestLocation();
+      const div = document.createElement('div');
+      const testLocation = new TestLocation();
       testLocation.history = ['/link'];
 
-      Router.run(routes, testLocation, function (Handler) {
-        React.render(<Handler/>, div, function () {
+      Router.run(routes, testLocation, function(Handler) {
+        React.render(<Handler/>, div, function() {
           click(div.querySelector('a'));
         });
       });
     });
 
-    it('transitions to the correct route', function (done) {
-      let div = document.createElement('div');
-      let testLocation = new TestLocation();
+    it('transitions to the correct route', function(done) {
+      const div = document.createElement('div');
+      const testLocation = new TestLocation();
       testLocation.history = ['/link'];
 
-      let ButtonLinkHandler = React.createClass({
+      const ButtonLinkHandler = React.createClass({
         handleClick() {
           // just here to make sure click handlers don't prevent it from happening
         },
@@ -140,29 +140,27 @@ describe('A ButtonLink', function () {
         }
       });
 
-      let routes = [
+      const routes = [
         <Route name="foo" handler={Foo} />,
         <Route name="link" handler={ButtonLinkHandler} />
       ];
 
-      let steps = [];
+      const steps = [];
 
-      steps.push(function () {
+      steps.push(function() {
         click(div.querySelector('a'), {button: 0});
       });
 
-      steps.push(function () {
+      steps.push(function() {
         expect(div.innerHTML).to.match(/Foo/);
         done();
       });
 
-      Router.run(routes, testLocation, function (Handler) {
-        React.render(<Handler/>, div, function () {
+      Router.run(routes, testLocation, function(Handler) {
+        React.render(<Handler/>, div, function() {
           steps.shift()();
         });
       });
     });
-
   });
-
 });