From ba3a508f4118789a96f8d49c1493137e0027a563 Mon Sep 17 00:00:00 2001 From: Jan Schneider Date: Fri, 7 Dec 2018 11:09:22 +0100 Subject: [PATCH 1/2] Retreive env var only once. --- tests/ApiTest.php | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/tests/ApiTest.php b/tests/ApiTest.php index d46453f..8b5fa92 100644 --- a/tests/ApiTest.php +++ b/tests/ApiTest.php @@ -76,9 +76,10 @@ public function testCreateSubscriber() public function testGetSubscriber() { + $groupId = getenv('GROUP_ID'); $response = self::$apiManager->getSubscriber( 'john.doe@example.org', - getenv('GROUP_ID') + $groupId ); $this->assertArrayHasKey('email', $response); @@ -86,7 +87,7 @@ public function testGetSubscriber() $response = self::$apiManager->getSubscriber( 'jane.doe@example.org', - getenv('GROUP_ID') + $groupId ); $this->assertArrayHasKey('error', $response); @@ -103,9 +104,10 @@ public function testGetSubscriber() public function testSetSubscriberStatus() { + $groupId = getenv('GROUP_ID'); $response = self::$apiManager->setSubscriberStatus( 'john.doe@example.org', - getenv('GROUP_ID'), + $groupId, true ); @@ -113,7 +115,7 @@ public function testSetSubscriberStatus() $response = self::$apiManager->getSubscriber( 'john.doe@example.org', - getenv('GROUP_ID') + $groupId ); $this->assertArrayHasKey('active', $response); @@ -121,7 +123,7 @@ public function testSetSubscriberStatus() $response = self::$apiManager->setSubscriberStatus( 'john.doe@example.org', - getenv('GROUP_ID'), + $groupId, false ); @@ -129,7 +131,7 @@ public function testSetSubscriberStatus() $response = self::$apiManager->getSubscriber( 'john.doe@example.org', - getenv('GROUP_ID') + $groupId ); $this->assertArrayHasKey('active', $response); @@ -140,14 +142,14 @@ public function testDeleteSubscriber() { $response = self::$apiManager->deleteSubscriber( 'john.doe@example.org', - getenv('GROUP_ID') + $groupId ); $this->assertTrue($response); $response = self::$apiManager->deleteSubscriber( 'jane.doe@example.org', - getenv('GROUP_ID') + $groupId ); $this->assertArrayHasKey('error', $response); From 53f6328ac5c395bf1f05d66bc23c785c01758887 Mon Sep 17 00:00:00 2001 From: Jan Schneider Date: Fri, 7 Dec 2018 11:21:25 +0100 Subject: [PATCH 2/2] Add @depends tags, because those tests depend on the subscriber being created earlier. --- tests/ApiTest.php | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tests/ApiTest.php b/tests/ApiTest.php index 8b5fa92..5570f01 100644 --- a/tests/ApiTest.php +++ b/tests/ApiTest.php @@ -74,6 +74,9 @@ public function testCreateSubscriber() $this->assertEquals('john.doe@example.org', $response['email']); } + /** + * @depends testCreateSubscriber + */ public function testGetSubscriber() { $groupId = getenv('GROUP_ID'); @@ -102,6 +105,9 @@ public function testGetSubscriber() ); } + /** + * @depends testCreateSubscriber + */ public function testSetSubscriberStatus() { $groupId = getenv('GROUP_ID'); @@ -138,6 +144,9 @@ public function testSetSubscriberStatus() $this->assertFalse($response['active']); } + /** + * @depends testCreateSubscriber + */ public function testDeleteSubscriber() { $response = self::$apiManager->deleteSubscriber(