Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,18 @@ All notable changes to this project will be documented in this file. Dates are d

Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).

#### [1.3.0](https://github.com/rdkcentral/start-parodus/compare/1.2.1...1.3.0)

- RDKB-61958: Parodus-Start coverity issues fix [`#18`](https://github.com/rdkcentral/start-parodus/pull/18)
- Merge tag '1.2.1' into develop [`e3f03e0`](https://github.com/rdkcentral/start-parodus/commit/e3f03e09ed0c710fd15660aabd2c8f84f2522f9f)

#### [1.2.1](https://github.com/rdkcentral/start-parodus/compare/1.2.0...1.2.1)

> 23 October 2025

- RDKCOM-5417: RDKBDEV-3270 ,RDKBACCL-1001 : Code Changes for the New W… [`#15`](https://github.com/rdkcentral/start-parodus/pull/15)
- RDKCOM-5417: RDKBDEV-3270 ,RDKBACCL-1001 : Code Changes for the New Webpa Implementation [`30d5069`](https://github.com/rdkcentral/start-parodus/commit/30d50699849c78dc958642e10e86296cb2bcec3d)
- Updating CHANGELOG.md for new release tag 1.2.1 [`fa100ac`](https://github.com/rdkcentral/start-parodus/commit/fa100ac8998a5e2996a35ad008ae30d72ce3a394)
- Merge tag '1.2.0' into develop [`00f1b0a`](https://github.com/rdkcentral/start-parodus/commit/00f1b0a76d1edfdd0aef6e4c575d080cd2724e15)

#### [1.2.0](https://github.com/rdkcentral/start-parodus/compare/1.1.0...1.2.0)
Expand Down
24 changes: 13 additions & 11 deletions source/parodusStart/start_parodus.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* If not stated otherwise in this file or this component's Licenses.txt file the

Check failure on line 2 in source/parodusStart/start_parodus.c

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected

Source code with 'Apache-2.0' license found in local file 'source/parodusStart/start_parodus.c' (Match: rdkb/components/generic/startParodus/rdkb/components/generic/startParodus/1, 1786 lines, url: https://code.rdkcentral.com/r/plugins/gitiles/rdkb/components/generic/startParodus/+archive/RDKB-RELEASE-TEST-DUNFELL-1.tar.gz, file: source/parodusStart/start_parodus.c)
* following copyright and licenses apply:
*
* Copyright 2019 RDK Management
Expand Down Expand Up @@ -923,7 +923,7 @@
if (NULL != fp)
{
char str[255] = {'\0'};
while(fscanf(fp,"%s", str) != EOF)
while(fscanf(fp,"%254s", str) != EOF)
{
char *value = NULL;

Expand Down Expand Up @@ -1269,6 +1269,8 @@
char tempBuf[MAX_BUF_SIZE] ={'\0'};
int offset = 0, i=0, index=0;
char temp[MAX_VALUE_SIZE] = {'\0'};
const size_t fmtBufSize = 32;
char fmt[fmtBufSize];

for(i=0; i<count; i++)
{
Expand Down Expand Up @@ -1300,7 +1302,8 @@
char *t = strrchr(buf, '"');
if(t)
*t = '\0';
if(sscanf(buf, "%dX=\"%s\n", &index, temp) == 2 && index == i) {
snprintf(fmt, sizeof(fmt), "%%dX=\"%%%ds", MAX_VALUE_SIZE - 1);
if (sscanf(buf, fmt, &index, temp) == 2 && index == i) {
values[i] = (char *) malloc(sizeof(char)* MAX_VALUE_SIZE);
rc = strcpy_s(values[i], MAX_VALUE_SIZE, temp);
if(rc != EOK)
Expand Down Expand Up @@ -1596,7 +1599,7 @@
if (NULL != fp)
{
char str[255] = {'\0'};
while(fscanf(fp,"%s", str) != EOF)
while(fscanf(fp,"%254s", str) != EOF)
{
char *value = NULL;

Expand Down Expand Up @@ -1737,13 +1740,13 @@
}

FILE *f;
if ((f = popen(comp_status_cmd, "r")) == NULL)
{
if ((f = popen(comp_status_cmd, "r")) == NULL)
{
LogError("Error in getting status\n");
return;
}
/* Coverity Fix CID:62204 CHECKED_RETURN */
if( fscanf(f,"%s",comp_status) == EOF )
if( fscanf(f,"%31s",comp_status) == EOF )
LogError("Error in fscanf() return\n");
pclose(f);

Expand Down Expand Up @@ -1780,7 +1783,7 @@
if (NULL != fp)
{
char str[255] = {'\0'};
while(fscanf(fp,"%s", str) != EOF)
while(fscanf(fp,"%254s", str) != EOF)
{
char *value = NULL;
if((value = strstr(str, "UseSEBasedCert=")))
Expand Down Expand Up @@ -1820,7 +1823,7 @@
char useSECertValue[MAX_BUF_SIZE] = {'\0'};
getSECertSupport(useSECertValue);

if((NULL != useSECertValue) && (strncmp(useSECertValue, "true", 4) == 0))
if((strncmp(useSECertValue, "true", 4) == 0))
{
if(stat(SE_DEVICE_CERT, &devFatrib) == 0)
{
Expand All @@ -1833,15 +1836,14 @@
return 2;
}
}

if(((NULL != useSECertValue) && (strncmp(useSECertValue, "true", 4) == 0)) && (stat(SE_DEVICE_CERT, &devFatrib) == 0))
if(((strncmp(useSECertValue, "true", 4) == 0)) && (stat(SE_DEVICE_CERT, &devFatrib) == 0))
{
LogInfo("Dynamic xPKI SE Certificate procured\n");
rv = 1;
}
else if(stat(DEVICE_CERT, &devFatrib) == 0)
{
if((NULL != useSECertValue) && (strncmp(useSECertValue, "true", 4) == 0))
if((strncmp(useSECertValue, "true", 4) == 0))
{
LogInfo("xPKI SE Certificate not present, Using xPKI Dynamic Certificate\n");
}
Expand Down
Loading