RDKBACCL-1337:Image download fails after the 1st successful download using Firmware Upgrade method through xconf

Reason For Change: Firmware upgrade failing after 1st successful download using Firmware Upgrade.
Test Procedure: Firmware upgrade should pass after 1st successful download using Firmware Upgrade.
Risks : None
Signed-off-by: mahanteshchitt <[email protected]>

Author: mahanteshchitt

source/fwupgrade/fwupgrade_hal.c

@@ -600,7 +600,6 @@ INT fwupgrade_hal_download_reboot_now()
         int bs_512 = 512;
         int bs_1M = 1024 * 1024;
         char decompress_cmd[300];
-
         fprintf(stderr, "Entering %s\n", __func__);
         snprintf(wic_path, sizeof(wic_path), "/mnt/bootpart/%s", g_downloaded_file_name);
         // Step 1: Check if file exists
@@ -641,7 +640,6 @@ INT fwupgrade_hal_download_reboot_now()
                 fprintf(stderr, "Currently booted from ROOT-B, switching to ROOT-A\n");
                 strcpy(target_boot, "/dev/mmcblk0p3");
                 strcpy(target_root, "/dev/mmcblk0p4");
-		//umount("/dev/mmcblk0p4");
 
         } else {
                 fprintf(stderr, "Unsupported root partition_1: %s\n", g_root_partition);
@@ -748,7 +746,8 @@ INT fwupgrade_hal_download_reboot_now()
         write_image_to_device("/mnt/bootpart/fip.img", "/dev/mmcblk0p6", bs_512);
 	sync();
 	fprintf(stderr,"value of the xconf flag is %d\n", g_xconf_flag);
-	umount("MOUNT_POINT");
+	cleanup_mount(MOUNT_POINT_1);
+	umount(MOUNT_POINT_1);
 	sync();
 	fprintf(stderr,"All done. Rebooting...\n");
         system("/sbin/reboot");
@@ -1067,7 +1066,6 @@ int check_image_version(const char *g_firmwareVersion,
                 if (strcmp(passiveVersion, extractedVersion) == 0) {
                         fprintf(stderr,"Passive Partition already has required version (%s). Switching banks...\n",
                                 extractedVersion);
-
                         umount(MOUNT_POINT_2);
                         fwupgrade_hal_recover_image();
                         return -1;
@@ -1077,14 +1075,28 @@ int check_image_version(const char *g_firmwareVersion,
         } else {
                 fprintf(stderr, "Mount of passive partition failed\n");
         }
-
         umount(MOUNT_POINT_2);
         fprintf(stderr,"Neither active nor passive have the required version. Proceeding with upgrade...\n");
         return RETURN_OK;
 
 
 }
 
+int cleanup_mount(const char *mnt)
+{
+    char cmd[256];
+
+    snprintf(cmd, sizeof(cmd), "rm -rf %s/*", mnt);
+
+    if (system(cmd) != 0) {
+        fprintf(stderr, "Failed to cleanup %s\n", mnt);
+        return -1;
+    }
+
+    sync();
+    return 0;
+}
+
 int get_image_version(const char *filePath, char *outVersion, size_t outSize)
 {
 	FILE *fp = fopen(filePath, "r");