RDKEMW-16730 : Evaluation on finding invalid markers in entservices repos#245
Open
srinibas15 wants to merge 3 commits intodevelopfrom
Open
RDKEMW-16730 : Evaluation on finding invalid markers in entservices repos#245srinibas15 wants to merge 3 commits intodevelopfrom
srinibas15 wants to merge 3 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a small set of telemetry marker names in the device settings RPC services so the emitted events use the required *_split identifiers instead of the previous invalid markers.
Changes:
- Renamed the persistent HDMI 4K resolution telemetry event in
dsVideoPort. - Renamed the HDMI Rx Sense OFF telemetry event in
dsDisplay. - Renamed two passthrough-related audio telemetry events in
dsAudio.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
rpc/srv/dsVideoPort.c |
Updates the HDMI resolution telemetry marker emitted during video port manager initialization. |
rpc/srv/dsDisplay.c |
Updates the telemetry marker sent when Rx Sense changes to OFF. |
rpc/srv/dsAudio.c |
Updates telemetry markers for ARC passthrough initialization and persisted passthrough mode changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
194
to
195
| char telemetryValue[128] = {0}; | ||
| snprintf(telemetryValue, sizeof(telemetryValue), "The Persistent HDMI resolution read is %s", _dsHDMIResolution.c_str()); |
Comment on lines
2087
to
2088
| char telemetryValue[128] = {0}; | ||
| snprintf(telemetryValue, sizeof(telemetryValue), "dsSetStereoMode The HDMI ARC Port Audio Settings Mode is %d", _srv_HDMI_ARC_Audiomode); |
Comment on lines
2752
to
+2755
| char telemetryValue[128] = {0}; | ||
| snprintf(telemetryValue, sizeof(telemetryValue), "The HDMI Audio Mode Setting From Persistent is %d", param->toPersist); | ||
| TELEMETRY_EVENT_STRING("SYS_INFO_Userpassthruenable", telemetryValue); | ||
| // TELEMETRY_EVENT_STRING("SYS_INFO_Userpassthruenable_split", telemetryValue); | ||
| TELEMETRY_EVENT_INT("SYS_INFO_Userpassthruenable", 1); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason For Change: Replacing with the required events for Invalid markers
Test procedure : Compile and Verify
version: patch
Priority: P2