webconfig: add Mode field support for radio capability#1110
Open
nefiguclu wants to merge 1 commit intordkcentral:developfrom
Open
webconfig: add Mode field support for radio capability#1110nefiguclu wants to merge 1 commit intordkcentral:developfrom
nefiguclu wants to merge 1 commit intordkcentral:developfrom
Conversation
Add support for new "Mode" parameter in radio capability webconfig encode/decode flow. The Mode value is now parsed from incoming JSON, stored in radio_cap->mode[0], and propagated to EasyMesh translation and encoder output. Issue: RDKBWIFI-428 Signed-off-by: Nefi Guclu <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for a new Mode attribute in the radio capability webconfig flow so it is carried end-to-end (decode → internal storage → EasyMesh translation → encode).
Changes:
- Encode
Modeinto the radiocap JSON payload (radiocap->mode[0]). - Decode
Modefrom incoming radiocap JSON intoradio_cap->mode[0]. - Propagate the decoded
Modeinto EasyMesh radio capability translation (cap_info->mode).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| source/webconfig/wifi_encoder.c | Adds Mode to radiocap JSON output. |
| source/webconfig/wifi_decoder.c | Parses Mode from radiocap JSON into radio_cap->mode[0]. |
| source/webconfig/wifi_easymesh_translator.c | Copies radio_cap->mode[0] into the EasyMesh radio cap info (cap_info->mode). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4850
to
+4857
| value_object = cJSON_GetObjectItem(object, "Mode"); | ||
| if ((value_object == NULL) || (cJSON_IsNumber(value_object) == false)) { | ||
| wifi_util_error_print(WIFI_WEBCONFIG, "%s:%d: Validation Failed\n", __func__, __LINE__); | ||
| return webconfig_error_decode; | ||
| } | ||
|
|
||
| radio_cap->mode[0] = value_object->valuedouble; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for new "Mode" parameter in radio capability webconfig encode/decode flow. The Mode value is now parsed from incoming JSON, stored in radio_cap->mode[0], and propagated to EasyMesh translation and encoder output.
Issue: RDKBWIFI-428