RDKEMW-10995: Fix to prevent double close issue#409
Merged
goruklu merged 2 commits intordkcentral:developfrom Feb 10, 2026
Merged
RDKEMW-10995: Fix to prevent double close issue#409goruklu merged 2 commits intordkcentral:developfrom
goruklu merged 2 commits intordkcentral:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a file-descriptor lifecycle issue in the Logging plugin’s FileSink to prevent accidental double-closing and to correctly treat fd 0 as valid.
Changes:
- Treat
/dev/nullfd as valid when it is>= 0(not just> 0) when falling back from a failed logfile open. - Update
FileSinkdestructor to avoid closing the same fd twice and to close the correct descriptors. - Minor formatting/line-ending adjustment at end of file.
Comments suppressed due to low confidence (1)
rdkPlugins/Logging/source/FileSink.cpp:84
- If opening the log file fails and /dev/null also failed to open (mDevNullFd < 0), mOutputFileFd remains negative. Downstream writes (e.g., DumpLog writes to mOutputFileFd) will then repeatedly hit EBADF and may spam logs. Consider explicitly handling this case by disabling file output (e.g., keeping a NullSink behavior), or ensuring DumpLog early-returns when both fds are invalid so we never write/close an invalid fd.
mOutputFileFd = openFile(mOutputFilePath);
if (mOutputFileFd < 0)
{
// Couldn't open our output file, send to /dev/null to avoid blocking
AI_LOG_SYS_ERROR(errno, "Failed to open container logfile - sending to /dev/null");
if (mDevNullFd >= 0)
{
mOutputFileFd = mDevNullFd;
}
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sasikumartech
approved these changes
Feb 10, 2026
B-Larsen
approved these changes
Feb 10, 2026
goruklu
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added proper fd validation and avoids closing the same fd twice
Type of Change
Requires Bitbake Recipe changes?
meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updatingSRC_REV)