RDKEMW-10995: Fix to prevent double close issue#407
Closed
ks734 wants to merge 2 commits intordkcentral:mainfrom
Closed
RDKEMW-10995: Fix to prevent double close issue#407ks734 wants to merge 2 commits intordkcentral:mainfrom
ks734 wants to merge 2 commits intordkcentral:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a double-close issue in the FileSink destructor by adding proper file descriptor validation and preventing the same fd from being closed twice. The fix ensures that when the output file cannot be opened and falls back to /dev/null, the destructor correctly handles cleanup without attempting to close the same file descriptor twice.
Changes:
- Updated fd validation from
> 0to>= 0to correctly handle all valid Unix file descriptors (including stdin/fd 0) - Added a check in the destructor to prevent closing mOutputFileFd when it points to the same fd as mDevNullFd
- Reordered the close operations to close mOutputFileFd before mDevNullFd with proper validation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added proper fd validation and avoids closing the same fd twice
Test Procedure
How to test this PR (if applicable)
Type of Change
Requires Bitbake Recipe changes?
meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updatingSRC_REV)