diff --git a/rdkPlugins/Logging/source/FileSink.cpp b/rdkPlugins/Logging/source/FileSink.cpp index 4beb5fe6..44dec051 100644 --- a/rdkPlugins/Logging/source/FileSink.cpp +++ b/rdkPlugins/Logging/source/FileSink.cpp @@ -77,7 +77,7 @@ FileSink::FileSink(const std::string &containerId, std::shared_ptr 0) + if (mDevNullFd >= 0) { mOutputFileFd = mDevNullFd; } @@ -88,17 +88,20 @@ FileSink::FileSink(const std::string &containerId, std::shared_ptr= 0 && mOutputFileFd != mDevNullFd) { - AI_LOG_SYS_ERROR(errno, "Failed to close /dev/null"); + if (close(mOutputFileFd) < 0) + { + AI_LOG_SYS_ERROR(errno, "Failed to close output file"); + } } - if (mOutputFileFd > 0) + if (mDevNullFd >= 0) { - if (close(mOutputFileFd) < 0) + if (close(mDevNullFd) < 0) { - AI_LOG_SYS_ERROR(errno, "Failed to close output file"); + AI_LOG_SYS_ERROR(errno, "Failed to close /dev/null"); } } } @@ -264,4 +267,4 @@ int FileSink::openFile(const std::string &pathName) } return openedFd; -} \ No newline at end of file +} diff --git a/rdkPlugins/Logging/source/FileSink.h b/rdkPlugins/Logging/source/FileSink.h index 5a315fd0..35ab2503 100644 --- a/rdkPlugins/Logging/source/FileSink.h +++ b/rdkPlugins/Logging/source/FileSink.h @@ -49,4 +49,4 @@ class FileSink : public ILoggingSink char mBuf[PTY_BUFFER_SIZE]; std::mutex mLock; -}; \ No newline at end of file +};