Skip to content

Commit c402653

Browse files
committed
docs(readme): remove deepmerge-ts
1 parent a7a5a20 commit c402653

File tree

2 files changed

+4
-25
lines changed

2 files changed

+4
-25
lines changed

README.md

+2-12
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,10 @@ Get the complete changelog here: https://github.com/rbalet/ngx-translate-multi-h
2323

2424
We assume that you already installed [ngx-translate](https://github.com/ngx-translate/core).
2525

26-
Now you need to install the npm module for `MultiTranslateHttpLoader`:
27-
[deepmerge-ts](https://www.npmjs.com/package/deepmerge-ts) may also need to be installed _should be done automatically though_
26+
Now you need to install the npm module for `MultiTranslateHttpLoader`:
2827

2928
```sh
3029
npm install ngx-translate-multi-http-loader
31-
npm install deepmerge-ts
3230
```
3331

3432
Choose the version corresponding to your Angular version:
@@ -102,23 +100,15 @@ export function HttpLoaderFactory(_httpBackend: HttpBackend) {
102100
}
103101
```
104102

105-
The loader will merge all translation files from the server using [deepmerge-ts](https://www.npmjs.com/package/deepmerge-ts).
103+
The loader will merge all translation files from the server
106104

107105

108106
## Possible error & Bugfix
109-
### Can't resolve 'deepmerge-ts'
110-
1. run `npm i deepmerge-ts`
111-
112-
This is due to some version of npm not being able to download peerDependencies properly.
113-
114-
I decided to **not** move it under dependencies since it's considered to be a bad practice.
115107

116108
### values.at is not a function
117109
1. Install `core-js`
118110
2. In `polyfills.ts`, add `import 'core-js/modules/es.array.at'`
119111

120-
`deepmerge-ts@5` uses `Array.at`, which is [not supported](https://caniuse.com/?search=array.at) in _not so_ old versions of Safari `< 15.4`.
121-
122112

123113
## Authors and acknowledgment
124114
* maintainer [Raphaël Balet](https://github.com/rbalet)

projects/multi-http-loader/README.md

+2-13
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,10 @@ Get the complete changelog here: https://github.com/rbalet/ngx-translate-multi-h
2323

2424
We assume that you already installed [ngx-translate](https://github.com/ngx-translate/core).
2525

26-
Now you need to install the npm module for `MultiTranslateHttpLoader`:
27-
[deepmerge-ts](https://www.npmjs.com/package/deepmerge-ts) may also need to be installed _should be done automatically though_
26+
Now you need to install the npm module for `MultiTranslateHttpLoader`:
2827

2928
```sh
3029
npm install ngx-translate-multi-http-loader
31-
npm install deepmerge-ts
3230
```
3331

3432
Choose the version corresponding to your Angular version:
@@ -102,23 +100,14 @@ export function HttpLoaderFactory(_httpBackend: HttpBackend) {
102100
}
103101
```
104102

105-
The loader will merge all translation files from the server using [deepmerge-ts](https://www.npmjs.com/package/deepmerge-ts).
103+
The loader will merge all translation files from the server
106104

107105

108106
## Possible error & Bugfix
109-
### Can't resolve 'deepmerge-ts'
110-
1. run `npm i deepmerge-ts`
111-
112-
This is due to some version of npm not being able to download peerDependencies properly.
113-
114-
I decided to **not** move it under dependencies since it's considered to be a bad practice.
115-
116107
### values.at is not a function
117108
1. Install `core-js`
118109
2. In `polyfills.ts`, add `import 'core-js/modules/es.array.at'`
119110

120-
`deepmerge-ts@5` uses `Array.at`, which is [not supported](https://caniuse.com/?search=array.at) in _not so_ old versions of Safari `< 15.4`.
121-
122111

123112
## Authors and acknowledgment
124113
* maintainer [Raphaël Balet](https://github.com/rbalet)

0 commit comments

Comments
 (0)