Skip to content

Commit 9492caa

Browse files
authored
Merge pull request #25 from odpf/refactor/alert_credentials_endpoint
refactor: update alert credentials api endpoint
2 parents 1448966 + d558e06 commit 9492caa

File tree

4 files changed

+140
-140
lines changed

4 files changed

+140
-140
lines changed

api/alertmanager_test.go

+7-7
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ func TestGetAlertCredentials(t *testing.T) {
6464
router := New(&service.Container{
6565
AlertmanagerService: alertmanagerServiceMock,
6666
}, nil, getPanicLogger())
67-
r, err := http.NewRequest(http.MethodGet, "/alertingCredentials/teams/hydra", nil)
67+
r, err := http.NewRequest(http.MethodGet, "/teams/hydra/credentials", nil)
6868
if err != nil {
6969
t.Fatal(err)
7070
}
@@ -99,7 +99,7 @@ func TestGetAlertCredentials(t *testing.T) {
9999
router := New(&service.Container{
100100
AlertmanagerService: alertmanagerServiceMock,
101101
}, nil, getPanicLogger())
102-
r, err := http.NewRequest(http.MethodGet, "/alertingCredentials/teams/hydra", nil)
102+
r, err := http.NewRequest(http.MethodGet, "/teams/hydra/credentials", nil)
103103
if err != nil {
104104
t.Fatal(err)
105105
}
@@ -130,7 +130,7 @@ func TestUpdateAlertCredentials(t *testing.T) {
130130
"webhook": "http://warning.com"
131131
}
132132
}}`)
133-
r, err := http.NewRequest(http.MethodPut, "/alertingCredentials/teams/myTeam", bytes.NewBuffer(payload))
133+
r, err := http.NewRequest(http.MethodPut, "/teams/myTeam/credentials", bytes.NewBuffer(payload))
134134
if err != nil {
135135
t.Fatal(err)
136136
}
@@ -161,7 +161,7 @@ func TestUpdateAlertCredentials(t *testing.T) {
161161
"webhook": "http://warning.com"
162162
}
163163
}}`)
164-
r, err := http.NewRequest(http.MethodPut, "/alertingCredentials/teams/myTeam", bytes.NewBuffer(payload))
164+
r, err := http.NewRequest(http.MethodPut, "/teams/myTeam/credentials", bytes.NewBuffer(payload))
165165
if err != nil {
166166
t.Fatal(err)
167167
}
@@ -192,7 +192,7 @@ func TestUpdateAlertCredentials(t *testing.T) {
192192
"webhook": "http://warning.com"
193193
}
194194
}}`)
195-
r, err := http.NewRequest(http.MethodPut, "/alertingCredentials/teams/myTeam", bytes.NewBuffer(payload))
195+
r, err := http.NewRequest(http.MethodPut, "/teams/myTeam/credentials", bytes.NewBuffer(payload))
196196
if err != nil {
197197
t.Fatal(err)
198198
}
@@ -226,7 +226,7 @@ func TestUpdateAlertCredentials(t *testing.T) {
226226
"webhook": "http://warning.com"
227227
}
228228
}}`)
229-
r, err := http.NewRequest(http.MethodPut, "/alertingCredentials/teams/myTeam", bytes.NewBuffer(payload))
229+
r, err := http.NewRequest(http.MethodPut, "/teams/myTeam/credentials", bytes.NewBuffer(payload))
230230
if err != nil {
231231
t.Fatal(err)
232232
}
@@ -261,7 +261,7 @@ func TestUpdateAlertCredentials(t *testing.T) {
261261
"webhook": "http://warning.com"
262262
}
263263
}}`)
264-
r, err := http.NewRequest(http.MethodPut, "/alertingCredentials/teams/myTeam", bytes.NewBuffer(payload))
264+
r, err := http.NewRequest(http.MethodPut, "/teams/myTeam/credentials", bytes.NewBuffer(payload))
265265
if err != nil {
266266
t.Fatal(err)
267267
}

0 commit comments

Comments
 (0)