Skip to content

Commit 57e8456

Browse files
committed
reset medalist arrays - don't need to call $("#bronze-podium").empty() anymore
1 parent 4d2ce08 commit 57e8456

File tree

2 files changed

+3
-15
lines changed

2 files changed

+3
-15
lines changed

examples/modular-backbone/js/views/contributors/ContributorsListView.js

+2-13
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,10 @@ define([
2121
that.bind("reset", that.clearView);
2222
},
2323

24-
clearListView : function(){
24+
resetMedalists : function(){
2525

2626
var that = this;
2727

28-
console.log("clearing sub sub view");
29-
30-
$("#gold-podium").empty();
31-
$("#silver-podium").empty();
32-
$("#bronze-podium").empty();
33-
3428
that.goldContributors = [];
3529
that.silverContributors = [];
3630
that.bronzeContributors = [];
@@ -43,7 +37,7 @@ define([
4337
// something to do with how it's animating I think...not sure
4438
var that = this;
4539

46-
that.clearListView();
40+
that.resetMedalists();
4741

4842
that.awardMedals(this.collection.models);
4943

@@ -151,8 +145,6 @@ define([
151145

152146
var that = this;
153147

154-
console.log("animating...");
155-
156148
$("#gold-podium").hide();
157149
$("#silver-podium").hide();
158150
$("#bronze-podium").hide();
@@ -180,10 +172,7 @@ define([
180172
$( animateId ).delay(bronzeDelayCount).slideDown('slow');
181173
bronzeDelayCount += bronzeDelayInc;
182174
});
183-
184175

185-
console.log(bronzeDelayCount);
186-
187176
// animate in silver
188177
$("#silver-podium").find(".base").hide();
189178
$("#silver-podium").find(".base").slideDown('slow').delay(bronzeDelayCount);

examples/modular-backbone/js/views/contributors/ContributorsView.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,8 @@ define([
44
'backbone',
55
'collections/contributors/ContributorsCollection',
66
'views/contributors/ContributorsListView',
7-
'events/contributors/ContributorsEvent',
87
'text!templates/contributors/contributorsTemplate.html'
9-
], function($, _, Backbone, ContributorsCollection, ContributorsListView, ContributorsEvent, contributorsTemplate){
8+
], function($, _, Backbone, ContributorsCollection, ContributorsListView, contributorsTemplate){
109

1110
//var contributorsListView;
1211

0 commit comments

Comments
 (0)