Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim.lsp.buf.implementation not opening guihua window (neovim +0.11) #321

Closed
ddaniel27 opened this issue Apr 1, 2025 · 6 comments
Closed

Comments

@ddaniel27
Copy link

Hey, I hope you are Ok. I update my neovim as well as all my config for +0.11, but I found a bug with navigator.
When I use the vim.lsp.buf.incoming_calls (i.e. <Leader>gi) the floating window is showed as expected

Image

But when I use the vim.lsp.buf.implementation (i.e. gi) just the quickfix window is showed

Image

I tried to enable the debug option, but the logs are not showing any error. Also I tried with my configuration and the one in the playground folder (showed in the screenshots). Also I tried in both Linux and OSX with same results.

I tried to debug but I'm not sure what could be the error. Thanks in advance for your help!

Let me know if more information is needed

@ray-x
Copy link
Owner

ray-x commented Apr 1, 2025

Maybe check config:

{
lsp={
    implementation = { enable = true },
}}

Also check output ofLspKeymaps

@ddaniel27
Copy link
Author

I tried that but same result.

LspKeymaps
Image

Updated config in playground/init.lua
Image

Calling vim.lsp.buf.implementation (i.e. gi in normal mode) result
Image

Also tried to set lsp.implementation.enable=true in my own config yesterday with same result.

@ray-x
Copy link
Owner

ray-x commented Apr 1, 2025

Ok, seems the neovim 0.11 handler override is not working in some scenarios.
I added a function `

        require('navigator.implementation').implementation_call()

you can map it to your key, e.g. gi in config.

@ddaniel27
Copy link
Author

Yeah, can confirm this works. For future reference, this is how I configured in my config files

require('navigator').setup({
  keymaps = {
          {
            key = 'gi',
            func = require('navigator.implementation').implementation_call,
            desc = 'implementation',
          },
  }

Thanks for this fix!

@ddaniel27 ddaniel27 changed the title vim.lsp.buf.implementation not opening guihua window vim.lsp.buf.implementation not opening guihua window (neovim +0.11) Apr 1, 2025
@ray-x
Copy link
Owner

ray-x commented Apr 1, 2025

I pushed a fix for it, please check if it works for you. Thanks

@ddaniel27
Copy link
Author

I updated the plugin and my config to avoid that remap. Everything works as expected. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants