Skip to content

ray docker images do not have uvloop installed #25023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fkaleo opened this issue May 20, 2022 · 5 comments · Fixed by #25027
Open

ray docker images do not have uvloop installed #25023

fkaleo opened this issue May 20, 2022 · 5 comments · Fixed by #25027
Assignees
Labels
P2 Important issue, but not time-critical serve Ray Serve Related Issue

Comments

@fkaleo
Copy link
Contributor

fkaleo commented May 20, 2022

It looks like uvloop is not a dependency of uvicorn but only of uvicorn[standard as per the documentation of uvicorn:

$ pip install uvicorn

This will install uvicorn with minimal (pure Python) dependencies.

$ pip install uvicorn[standard]

This will install uvicorn with "Cython-based" dependencies (where possible) and other "optional extras".

In this context, "Cython-based" means the following:

the event loop uvloop will be installed and used if possible.

https://www.uvicorn.org/#quickstart

Originally posted by @fkaleo in #9216 (comment)

@fkaleo
Copy link
Contributor Author

fkaleo commented May 20, 2022

I could verify this on Docker image rayproject/ray:1.12.1-py39 with:
python -c "import uvloop"

@fkaleo
Copy link
Contributor Author

fkaleo commented May 20, 2022

This is a "new" behaviour of uvicorn since august 2020 introduced in release 0.12.0 by encode/uvicorn#666

@mwtian
Copy link
Member

mwtian commented May 20, 2022

Looks you have a pending PR for this. Thanks for making the contribution!

@mwtian mwtian added serve Ray Serve Related Issue P1 Issue that should be fixed within a few weeks labels May 20, 2022
@fkaleo
Copy link
Contributor Author

fkaleo commented Jun 21, 2022

Fix was reverted by #25530

@fkaleo
Copy link
Contributor Author

fkaleo commented Jun 21, 2022

@simon-mo can we reponen?

@simon-mo simon-mo reopened this Jun 23, 2022
@hora-anyscale hora-anyscale added P2 Important issue, but not time-critical and removed P1 Issue that should be fixed within a few weeks labels Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Important issue, but not time-critical serve Ray Serve Related Issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants