[history server] [collector] Address log collector's review comments

[JiangJiaWei1103]

This requirement is first introduce in #4241 (comment). The current progress is in this PR, KunWuLuan#1.

As the original log collector PR is merged. We open this issue to track the progress.

[JiangJiaWei1103]

Hi @Future-Outlier,

Should we add this to the collector epic?

I'll open a PR with the previous progress tmr. Thanks.

[JiangJiaWei1103]

Hi @Future-Outlier,

Because the review has grown to 30+ comments across many unrelated areas, I suggest splitting the work into several smaller PRs. Each PR will have a single clear intent, making reviews faster and easier to reason about.

1. Refactor PR

These changes don't change runtime behavior. They only improve code structure and clarity.

• Align timestamp format with the design doc
• Remove unused variable
• Move constants into constant.go
• Rename collector variable to avoid naming conflicts
• Remove redundant validation logic
• Standardize variable declaration style
• Rename storage provider argument
• Make data and clusters explicit parameters of NewMockReader
• Rename creation time variable for clarity
• Rename environment variables
• Fix all typos (identifiers, not just comments)

2. Docs PR

These changes Improve code and CLI documentation so new contributors can understand how things work.

• Add step-by-step comments on key functions (similar to what we did in the e2e tests)
• Add usage descriptions for CLI args in main.go
• Remove package-level comments

3. Fix PR

These changes do affect behavior and fix things that can break, leak, or hang.

• Cancel contexts to prevent goroutine and resource leaks
• Always send HTTP responses so clients don’t hang
• Use more robust retry logic when reading file links
• Warn when uploads to S3 fail
• Retry failed log-file processing to prevent log loss
• Ensure background upload goroutines finish correctly
• Replace panic with log + os.Exit(1) for safer error handling

4. Storage PR

These changes improve and extend object-storage integration (S3/GCS and authentication).

• Check whether an S3 object exists before creating it
• Refactor S3 config helper functions
• Add GCS support
• Investigate AWS auth behavior
  • add the implementation of historyserver collector #4241 (comment)
  • add the implementation of historyserver collector #4241 (comment)
• Upgrade AWS SDK to v2
  • This is already tracked in a separate issue, so it will be handled there.

5. Chore/Build PR

These changes fix Docker and build tooling so images are reproducible and correct.

• Fix Go proxy settings in the Dockerfile
• Remove the historyserver component from the Dockerfile
• Remove history-server targets from the Makefile
• Make Dockerfile COPY commands explicit so only required sources are included

Instead of one huge mixed PR, I believe reviewers can review smaller PRs more intently and efficiently. Thanks!

[Future-Outlier]

Hi, @JiangJiaWei1103
let's discuss offline tonight, thank you for organizing these information.
it's great work.

[Future-Outlier]

I prefer do all in 1 PR, since we don't have a lot of maintainer bandwidth.

[JiangJiaWei1103]

No problem, let's fix them all in one pr, thanks!

As discussed yesterday, we'll split into two PRs, one fixing all review comments and the other for docs only.

Update (01/03/2026):

1. Got the "Refactor PR" section done