address comment

Author: seanlaii

ray-operator/apis/ray/v1/rayjob_types.go

@@ -85,8 +85,6 @@ const (
 	SidecarMode     JobSubmissionMode = "SidecarMode"     // Submit job via a sidecar container in the Ray head Pod
 )
 
-type DeletionPolicyType string
-
 // DeletionStrategy defines the deletion policies for a RayJob.
 // It allows for fine-grained control over resource cleanup after a job finishes.
 //
@@ -167,6 +165,8 @@ type DeletionPolicy struct {
 	Policy *DeletionPolicyType `json:"policy,omitempty"`
 }
 
+type DeletionPolicyType string
+
 const (
 	DeleteCluster DeletionPolicyType = "DeleteCluster" // To delete the entire RayCluster custom resource on job completion.
 	DeleteWorkers DeletionPolicyType = "DeleteWorkers" // To delete only the workers on job completion.

ray-operator/controllers/ray/utils/validation.go

@@ -216,7 +216,10 @@ func ValidateRayJobSpec(rayJob *rayv1.RayJob) error {
 		return fmt.Errorf("backoffLimit must be a positive integer")
 	}
 
-	return validateDeletionStrategy(rayJob)
+	if err := validateDeletionStrategy(rayJob); err != nil {
+		return err
+	}
+	return nil
 }
 
 func ValidateRayServiceMetadata(metadata metav1.ObjectMeta) error {