Skip to content

fix: docker build break after pnpm update - [CU-869d9edkd] #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AhmedAmrNabil wants to merge 5 commits into
base: chore/revert-self-runner
Choose a base branch
from
+12 −5
Open

fix: docker build break after pnpm update - [CU-869d9edkd] #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0aafd1d
fix: add cypress to ignored built dependencies
AhmedAmrNabil May 13, 2026
e5c253f
fix: add correct pnpm version to package.json
AhmedAmrNabil May 13, 2026
06e07b3
fix: include pnpm-workspace.yaml in Dockerfile dependency installation
AhmedAmrNabil May 13, 2026
273e08d
fix: add CI flag so husky doesn't build in docker
AhmedAmrNabil May 13, 2026
c586258
fix(deployment): remove hardcoded pnpm version from workflow
AhmedAmrNabil May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/code-quality-workflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ jobs:
- uses: actions/checkout@v4

- uses: pnpm/action-setup@v6
with:
version: 10.28.0

- uses: actions/setup-node@v4
with:
Expand Down
5 changes: 3 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ RUN corepack enable
# Stage 1: Build the application
FROM base AS build
ENV NODE_ENV=development
ENV CI=true

ARG NUXT_PUBLIC_RECAPTCHA_SITE_KEY
ARG NUXT_PUBLIC_DM_WS_URL
Expand All @@ -17,7 +18,7 @@ ENV NUXT_PUBLIC_DM_WS_URL=$NUXT_PUBLIC_DM_WS_URL
ENV RAVEN_TENOR_KEY=$RAVEN_TENOR_KEY

# Install dependencies
COPY package.json pnpm-lock.yaml ./
COPY package.json pnpm-lock.yaml pnpm-workspace.yaml ./
RUN --mount=type=cache,id=pnpm-store,target=/pnpm/store \
pnpm install --frozen-lockfile

Expand All @@ -40,7 +41,7 @@ FROM base
# Copy build output and necessary files
ENV NODE_ENV=production
COPY --from=build /app/.output /app/.output
COPY package.json ./
COPY package.json pnpm-lock.yaml pnpm-workspace.yaml ./

EXPOSE 3000
CMD ["pnpm", "start"]
9 changes: 8 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"generate": "nuxt generate",
"preview": "nuxt preview",
"postinstall": "nuxt prepare",
"prepare": "node -e \"if (process.env.NODE_ENV !== 'production') require('child_process').execSync('husky', {stdio: 'inherit'})\"",
"prepare": "node -e \"if (process.env.NODE_ENV !== 'production' && process.env.CI !== 'true') require('child_process').execSync('husky', {stdio: 'inherit'})\"",
"lint": "eslint . --ext .js,.ts,.vue --fix",
"lint:check": "eslint . --ext .js,.ts,.vue",
"format": "prettier --write .",
Expand Down Expand Up @@ -107,6 +107,13 @@
"engines": {
"node": ">=22.0.0"
},
"devEngines": {
"packageManager": {
"name": "pnpm",
"version": "10.28.0",
"onFail": "download"
}
},
"msw": {
"workerDirectory": [
"public"
Expand Down
1 change: 1 addition & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
ignoredBuiltDependencies:
- cypress
- msw
- unrs-resolver
- vue-demi
Expand Down