waveshare RP2040 lcd 1.28 incorrect pin assignments

[u6bkep]

src/boards/include/boards/waveshare_rp2040_lcd_1.28.h pin assignments are incorrect. correct pin assignments can be found in DEV_Config.h from waveshare.

specifically I have found that PICO_DEFAULT_SPI_CSN_PIN, and WAVESHARE_RP2040_LCD_RST_PIN are incorrect, but there may be others.

[kilograham]

if you have a PR to fix, then great

[u6bkep]

that is my intention. that project has temporarily stalled due to work, but I might have some time for it in the upcoming holidays.

[u6bkep]

I have discovered the problem is that the board in the pico-sdk is the WAVESHARE_RP2040_LCD and the board I have is the touch screen variant with a slightly different pin assignment. So I am preparing a pull request to add this board. The schematic for the touch variant lists a W25Q128JVSIQ as the flash chip, but the code defines a macro of PICO_BOOT_STAGE2_CHOOSE_W25Q080. Do I need to do anything special or can I just leave it as is?

[lurch]

@kilograham / @Wren6991 I know nothing about the compatibility between different flash chips and different BOOT_STAGE2 files - could you respond to the question in the previous comment please?