[BUG] librmm conda packages are shipping dependencies in the package #1833
Assignees
Labels
bug
Something isn't working
Comments
3 tasks
rapids-bot bot
pushed a commit
that referenced
this issue
Feb 24, 2025
Fixes redistribution of `rapids-logger` code which can cause clobbering. See #1833. After this change, the following paths should _not_ be in the `librmm` package: - `lib/librapids_logger.so` - `lib/cmake/rapids_logger/*` - `include/rapids_logger/*` Authors: - Bradley Dice (https://github.com/bdice) Approvers: - https://github.com/jakirkham - Gil Forsyth (https://github.com/gforsyth) URL: #1834
|
Re:CCCL, see #1307 (comment). |
VenkateshJaya
pushed a commit
to VenkateshJaya/rmm
that referenced
this issue
Mar 10, 2025
) Fixes redistribution of `rapids-logger` code which can cause clobbering. See rapidsai#1833. After this change, the following paths should _not_ be in the `librmm` package: - `lib/librapids_logger.so` - `lib/cmake/rapids_logger/*` - `include/rapids_logger/*` Authors: - Bradley Dice (https://github.com/bdice) Approvers: - https://github.com/jakirkham - Gil Forsyth (https://github.com/gforsyth) URL: rapidsai#1834
VenkateshJaya
pushed a commit
to VenkateshJaya/rmm
that referenced
this issue
Mar 10, 2025
) Fixes redistribution of `rapids-logger` code which can cause clobbering. See rapidsai#1833. After this change, the following paths should _not_ be in the `librmm` package: - `lib/librapids_logger.so` - `lib/cmake/rapids_logger/*` - `include/rapids_logger/*` Authors: - Bradley Dice (https://github.com/bdice) Approvers: - https://github.com/jakirkham - Gil Forsyth (https://github.com/gforsyth) URL: rapidsai#1834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently,
librmmis shipping headers and libraries from its dependencies. We need to clean this up so we don't clobber.This issue is similar in flavor to rapidsai/cudf#13230.
I think this should be a prerequisite for #1779, to prevent the problem from getting worse.
rapids-logger
#1528 fixed librmm's clobbering of spdlog and fmt headers. However, we are now shipping rapids-logger headers and .so files that should just come from including
rapids-loggeras a dependency. This is a simple fix for the recipe, which I filed in #1834.NVTX
For conda builds, NVTX should come from
nvtx-cconda packages, rather than being CPM-fetched and shipped ininclude/nvtx3/in thelibrmmpackage (which clobbersnvtx-c!). However, there is no CMake config being shipped with NVTX3 upstream, so we probably need to fix that first -- or provide our own CMake Find module so that it can be found locally. This may be a rapids-cmake project or a project for upstream NVTX. I filed an issue here: NVIDIA/NVTX#113CCCL
We are shipping a vendored CCCL in
librmm. We should probably transition this to userapids_core_dependenciesas proposed in #1307. I verified that this should contain the right files for our RAPIDS-vendored-CCCL installation, so the fix should be straightforward.The text was updated successfully, but these errors were encountered: