Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Audit enum fields re-exported from cudart to see if we can use the symbols (rather than matching values) #1745

Open
wence- opened this issue Dec 5, 2024 · 1 comment
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@wence-
Copy link
Contributor

wence- commented Dec 5, 2024

Is your feature request related to a problem? Please describe.

See discussion in #1743, we have an allocation_handle_type enum that re-exports enum values from cudart. In the past we copied values because the symbols didn't appear in cudart 11.2. It may be that they now exist in all supported versions.

This would mean that we don't accidentally end up with mismatching values between cudart and rmm. One hopes that the enum values are fowards compatible forever, but ...

@wence- wence- added ? - Needs Triage Need team to review and classify feature request New feature or request labels Dec 5, 2024
@bdice
Copy link
Contributor

bdice commented Dec 5, 2024

Yes, this is a good idea. For any enum values that are now present in all supported CUDA versions, we can do this. That would mean CUDA 11.2+ for sure, and possibly 11.4+. (We currently have some inconsistency in RMM around what our minimum CUDA version really is.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
Status: To-do
Development

No branches or pull requests

2 participants