Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plot with legend_label option to remove BokehDeprecationWarnings #132

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Plot with legend_label option to remove BokehDeprecationWarnings #132

merged 2 commits into from
Aug 24, 2023

Conversation

reoono
Copy link
Contributor

@reoono reoono commented Jun 17, 2022 •
edited
Loading

FIx #131

To remove BokehDeprecationWarnings, we changed the legend option to legend_label.
It can suppress warnings by environment variables such as BOKEH_PY_LOG_LEVEL.
But to follow API changes, we created this PR.

To be sure, we also tried other options and found the following errors and display errors, so we do not think there is a problem with the modification.

  • 'legend_field'.
ERROR:bokeh.core.validation.check:E-1001 (BAD_COLUMN_NAME): Glyph refers to nonexistent column name. This could either be due to a misspelling or typo, or due to an expected column being missing.
...
  • 'legend_group'.
ERROR:tornado.application:Uncaught exception GET /Machine-Resources (127.0.0.1)
HTTPServerRequest(protocol='http', host='127.0.0.1:9090', method='GET', uri='/Machine-Resources', version='HTTP/1.1', remote_ip='127.0.0.1')
Traceback (most recent call last):
...

@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@jacobtomlinson
Copy link
Member

ok to test

@jacobtomlinson jacobtomlinson mentioned this pull request Aug 24, 2023
Closed
@jacobtomlinson jacobtomlinson merged commit f40fe10 into rapidsai:branch-0.8 Aug 24, 2023
@jacobtomlinson jacobtomlinson mentioned this pull request Aug 24, 2023
Closed
jacobtomlinson added a commit that referenced this pull request Aug 24, 2023
@jacobtomlinson
Revert "remove bokeh warning (#132)"
3febefd 
This reverts commit f40fe10.
@jacobtomlinson jacobtomlinson mentioned this pull request Aug 24, 2023
Merged
jacobtomlinson added a commit that referenced this pull request Aug 24, 2023
@jacobtomlinson
Revert "remove bokeh warning (#132)" (#161)
f77266d 
This reverts commit f40fe10.
jacobtomlinson added a commit that referenced this pull request Aug 24, 2023
@jacobtomlinson
Revert "Revert "remove bokeh warning (#132)" (#161)"
9d8a45f 
This reverts commit f77266d.
jacobtomlinson added a commit that referenced this pull request Aug 24, 2023
@jacobtomlinson @reoono
Retarget #132 to branch-0.9 (#162)
b18df67 
* remove bokeh warning (#132)

Co-authored-by: Jacob Tomlinson <[email protected]>

* Revert "remove bokeh warning (#132)" (#161)

This reverts commit f40fe10.

* Revert "Revert "remove bokeh warning (#132)" (#161)"

This reverts commit f77266d.

---------

Co-authored-by: Reo Ono <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtomlinson jacobtomlinson jacobtomlinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BokehDeprecationWarnings with Bokeh v2.4.3
3 participants
@reoono @GPUtester @jacobtomlinson