Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bier import optional #29

Open
VibhuJawa opened this issue Nov 14, 2023 · 0 comments
Open

Make bier import optional #29

VibhuJawa opened this issue Nov 14, 2023 · 0 comments

Comments

@VibhuJawa
Copy link
Member

We should make bier import optional , we currently fail in an environment without beir because of below import:

https://github.com/NVIDIA-Merlin/crossfit/blob/3965dda2d6312fc7572a7917771b8afc3e9176a4/crossfit/backend/torch/op/vector_search.py#L3C1-L3C1

We should switch that to an optional dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VibhuJawa