Feature Request: The theme contains non-color configurations

[cavivie]

I would like to be able to configure the background image or opacity used by the theme in a custom theme, rather than just the color, and currently setting the window background image and opacity in the standalone theme config files does not seem to work. Is this intended, and if so, will this project accept feature requests for this?

[raphamorim]

Hey @cavivie I like the idea, it's something @benadam11 talked to me long time ago.

I think is a good idea, and allow even to set fonts.

My concern in the time was that theme file should be cross-platform, and back in time it couldn't. Now it can do it if we use Platform https://raphamorim.io/rio/docs/config/platform.

However themes should not set Shell (at least in my head it's a bit weird and can contain security issues). So if you implement this feature, either you use Platform and remove shell override if comes from theme or create a similar property like shell called ThemeOverrides idk, we can discuss in the PR.

[cavivie]

@raphamorim Thank you for your efforts!
Although I think that the theme configuration should not be included except for shell, I also think that the theme should only contain configurations that are closely related to the theme itself, rather than as many configuration items as possible, because this will cause the theme meaning to deviate. Do you think so?

If we classify by closely related to the theme, then there is a question here, what kind of configuration items should be listed as the theme and what kind should not be listed.

If we classify as much as possible instead of by theme, then I would like to call it sub-configuration instead of theme meaning. For example, the underlying main configuration (.config/rio/config.toml) can import sub-configuration (.config/rio/config.d/sub-conf-name.toml), and it can also be designed whether the sub-configuration can override the underlying main configuration.

More complicatedly, it is possible to combine sub-configuration and theme, but what is the best option at present, to be honest, I am not sure.

[raphamorim]

More complicatedly, it is possible to combine sub-configuration and theme, but what is the best option at present, to be honest, I am not sure.

Yea I would prefer to go this way.

themes/my-theme.toml would have colors definition and IF exists also Platform key.

that's good because people that vendor themes can actually specify how they want -exactly- Rio terminal would be. Probably the name theme would need to be updated in the future but we can start with it for now.